-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
virtualbox: 5.2.6 -> 5.2.8 #36127
virtualbox: 5.2.6 -> 5.2.8 #36127
Conversation
@GrahamcOfBorg build linuxPackages_latest.virtualbox linuxPackages_latest.virtualboxGuestAdditions linuxPackages.virtualbox linuxPackages.virtualboxGuestAdditions |
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Let's try this again. I think Borg grabbed your typo :) @GrahamcOfBorg build linuxPackages_latest.virtualbox linuxPackages_latest.virtualboxGuestAdditions linuxPackages.virtualbox linuxPackages.virtualboxGuestAdditions |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
x86_64-linux build timed out, can confirm it works locally FWIW. |
Failure on x86_64-linux (full log) Partial log (click to expand)
|
hmm, so the test fails for me locally but I don't think it's because of Virtualbox. I'd like somebody else to take a look at this |
Failure on x86_64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
You'll need the icu fix from #36130 if that was the problem you're seeing? I'll push a rebased version shortly, also kicking off a local build of the test :). |
cad031b
to
14e6686
Compare
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Failure on aarch64-linux (full log) Partial log (click to expand)
|
Still testing, but the VirtualBox wrapper ( |
Success on x86_64-linux (full log) Partial log (click to expand)
|
FWIW it appears the NixOS test for virtualbox was previously broken, before this change. Blargh. |
cc @aszlig |
Looks fine, but I'd like to merge this after fixing the current test failures, which are twofold: First, they fail for some reason and second they don't give any output from the guests since a while. |
Beep boop! Is there an issue or something tracking/investigating those test failures? |
@dtzWill: Well, for the latter, the fix is already in master (88530e0), the first however is caused by torvalds/linux@72f5e08, which has landed in kernel 4.14.8. VirtualBox tries to figure out the TSS, but seems to be unable to find the correct location. I'm currently trying to dig through the VirtualBox code to fix it. |
Awesome, thanks @aszlig ! |
:D Thanks! |
Update!
Also fixes guest additions w/4.15.
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)