Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bintools-wrapper: fix breakage on aarch64, where "isArm" is false #36129

Merged
merged 1 commit into from Feb 28, 2018
Merged

bintools-wrapper: fix breakage on aarch64, where "isArm" is false #36129

merged 1 commit into from Feb 28, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 28, 2018

Unintentionally changed in #35247

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
Copy link
Member Author

dtzWill commented Feb 28, 2018

@GrahamcOfBorg build stdenv.cc gcc7

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

these paths will be fetched (37.20 MiB download, 155.10 MiB unpacked):
  /nix/store/5yrxhk1wiwvgyz4hvj3nvlwmajw433rk-gcc-7.3.0-lib
  /nix/store/k4h6nvmbij9ikv30r6bdh10hqngc9hj1-gcc-7.3.0
  /nix/store/m81z2skf0g9pg8xv2lykq9l5sdxyi646-gcc-wrapper-7.3.0
copying path '/nix/store/5yrxhk1wiwvgyz4hvj3nvlwmajw433rk-gcc-7.3.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/k4h6nvmbij9ikv30r6bdh10hqngc9hj1-gcc-7.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/m81z2skf0g9pg8xv2lykq9l5sdxyi646-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
/nix/store/53h1zds6q5k4ab4l7430fbddn0l0iq1c-clang-wrapper-5.0.1
/nix/store/m81z2skf0g9pg8xv2lykq9l5sdxyi646-gcc-wrapper-7.3.0

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)


fetching path ‘/nix/store/7ygz301k24r5jaii99rmi7rinjkwbplj-gcc-wrapper-7.3.0’...

*** Downloading ‘https://cache.nixos.org/nar/16xl9sbgylvgrb6l77zh9jc9lvqvhah8v5yywkdrwifknky873a5.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/7ygz301k24r5jaii99rmi7rinjkwbplj-gcc-wrapper-7.3.0’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  6824  100  6824    0     0  23860      0 --:--:-- --:--:-- --:--:-- 23777

/nix/store/gqg2vrcq7krqi9rrl6pphvsg81sb8pjw-gcc-wrapper-7.3.0
/nix/store/7ygz301k24r5jaii99rmi7rinjkwbplj-gcc-wrapper-7.3.0

@Ericson2314 Ericson2314 merged commit 632761b into NixOS:master Feb 28, 2018
@Ericson2314
Copy link
Member

Ahhhhh. Sorry @dtzWill and @vcunat; I forgot that isArm doesn't apply to the entire arm family.

@dtzWill dtzWill deleted the fix/bintools-aarch64 branch February 28, 2018 15:55
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

these paths will be fetched (20.36 MiB download, 96.97 MiB unpacked):
  /nix/store/02wdcrzydpjdgygrifgkkxi5qsl5866w-gcc-7.3.0-lib
  /nix/store/2amadx7k6dklsmjmp6bp4cby8jrg73ay-gcc-wrapper-7.3.0
  /nix/store/mqv160qjigci73nwyfa9pk1a4aphlqnw-gcc-7.3.0
copying path '/nix/store/02wdcrzydpjdgygrifgkkxi5qsl5866w-gcc-7.3.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/mqv160qjigci73nwyfa9pk1a4aphlqnw-gcc-7.3.0' from 'https://cache.nixos.org'...
warning: SQLite database '/nix/var/nix/db/db.sqlite' is busy
copying path '/nix/store/2amadx7k6dklsmjmp6bp4cby8jrg73ay-gcc-wrapper-7.3.0' from 'https://cache.nixos.org'...
/nix/store/sw52c97xmgshcjaapn5wb1qwb2zgdszg-gcc-wrapper-7.3.0
/nix/store/2amadx7k6dklsmjmp6bp4cby8jrg73ay-gcc-wrapper-7.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@orivej orivej Awaiting requested review from orivej

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @Ericson2314