Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.POE: init at 1.367 #36117

Merged
merged 1 commit into from Mar 8, 2018
Merged

perlPackages.POE: init at 1.367 #36117

merged 1 commit into from Mar 8, 2018

Conversation

limeytexan
Copy link
Contributor

Motivation for this change

Add POE module from CPAN.

Note that I encountered bugs as part of this effort as documented in
the following github PRs and CPAN bug tickets:

https://github.com/rcaputo/poe/pull/25
https://rt.cpan.org/Ticket/Display.html?id=124495
POE-1.367 failed t/10_units/01_pod/03_pod_no404s.t

https://github.com/rcaputo/poe/pull/26
https://rt.cpan.org/Ticket/Display.html?id=124496
POE-1.367 failed t/10_units/01_pod/04_pod_linkcheck.t

... and these bugs are addressed by the perl-POE-1.367-pod_no404s.patch
and perl-POE-1.367-pod_linkcheck.patch files included with this patch,
respectively.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@limeytexan
perlPackages.POE: init at 1.367
1f37801 
Note that I encountered bugs as part of this effort as documented in
the following github PRs and CPAN bug tickets:

    rcaputo/poe#25
    https://rt.cpan.org/Ticket/Display.html?id=124495
	POE-1.367 failed t/10_units/01_pod/03_pod_no404s.t

    rcaputo/poe#26
    https://rt.cpan.org/Ticket/Display.html?id=124496
	POE-1.367 failed t/10_units/01_pod/04_pod_linkcheck.t

... and these bugs are addressed by the perl-POE-1.367-pod_no404s.patch
and perl-POE-1.367-pod_linkcheck.patch files included with this patch,
respectively.
@limeytexan limeytexan mentioned this pull request Mar 8, 2018
Merged
8 tasks
@Mic92
Copy link
Member

Mic92 commented Mar 8, 2018

@GrahamcOfBorg build perlPackages.POE

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/pyaxibpjv357fllvpw361l53z2zyz9ip-perl-POE-1.367/lib 
patching script interpreter paths in /nix/store/pyaxibpjv357fllvpw361l53z2zyz9ip-perl-POE-1.367
checking for references to /tmp/nix-build-perl-POE-1.367.drv-0 in /nix/store/pyaxibpjv357fllvpw361l53z2zyz9ip-perl-POE-1.367...
shrinking RPATHs of ELF executables and libraries in /nix/store/x3ppi87glc84rl1bxcx3wz88288wcjs2-perl-POE-1.367-devdoc
gzipping man pages under /nix/store/x3ppi87glc84rl1bxcx3wz88288wcjs2-perl-POE-1.367-devdoc/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/x3ppi87glc84rl1bxcx3wz88288wcjs2-perl-POE-1.367-devdoc
checking for references to /tmp/nix-build-perl-POE-1.367.drv-0 in /nix/store/x3ppi87glc84rl1bxcx3wz88288wcjs2-perl-POE-1.367-devdoc...
/nix/store/pyaxibpjv357fllvpw361l53z2zyz9ip-perl-POE-1.367

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

post-installation fixup
Moving /nix/store/6lbkcfjdrnniblaz9rivx6z41z5zacig-perl-POE-1.367/share/man/man3 to /nix/store/f9ml1s9bi9l93wgd13y3d3bzarhcghq1-perl-POE-1.367-devdoc/share/man/man3
Removing empty /nix/store/6lbkcfjdrnniblaz9rivx6z41z5zacig-perl-POE-1.367/share/man/ and (possibly) its parents
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/6lbkcfjdrnniblaz9rivx6z41z5zacig-perl-POE-1.367/lib
patching script interpreter paths in /nix/store/6lbkcfjdrnniblaz9rivx6z41z5zacig-perl-POE-1.367
gzipping man pages under /nix/store/f9ml1s9bi9l93wgd13y3d3bzarhcghq1-perl-POE-1.367-devdoc/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/f9ml1s9bi9l93wgd13y3d3bzarhcghq1-perl-POE-1.367-devdoc
/nix/store/6lbkcfjdrnniblaz9rivx6z41z5zacig-perl-POE-1.367

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2p5c0gcx34lykrk875845p1yhk8020fp-perl-POE-1.367/lib
patching script interpreter paths in /nix/store/2p5c0gcx34lykrk875845p1yhk8020fp-perl-POE-1.367
checking for references to /build in /nix/store/2p5c0gcx34lykrk875845p1yhk8020fp-perl-POE-1.367...
shrinking RPATHs of ELF executables and libraries in /nix/store/zsj3rwfib65y6xa9gcbbj8cr9w3wfnl7-perl-POE-1.367-devdoc
gzipping man pages under /nix/store/zsj3rwfib65y6xa9gcbbj8cr9w3wfnl7-perl-POE-1.367-devdoc/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/zsj3rwfib65y6xa9gcbbj8cr9w3wfnl7-perl-POE-1.367-devdoc
checking for references to /build in /nix/store/zsj3rwfib65y6xa9gcbbj8cr9w3wfnl7-perl-POE-1.367-devdoc...
/nix/store/2p5c0gcx34lykrk875845p1yhk8020fp-perl-POE-1.367

@Mic92 Mic92 merged commit f9d3886 into NixOS:master Mar 8, 2018
@limeytexan limeytexan deleted the perlPackages-POE branch March 13, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@limeytexan @Mic92 @GrahamcOfBorg