Eduvpn client: init at 1.0.1 #36122

leenaars · 2018-02-28T14:29:11Z

Motivation for this change

A user-friendly tool for people inside educational and research institutions to set up their VPN networks. Useful for many people to protect against rogue networks, snooping etc.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2018-02-28T14:58:38Z

@GrahamcOfBorg build eduvpn-client

Mic92 · 2018-02-28T14:59:04Z

@GrahamcOfBorg build pythonPackages.eduvpn-client python3Packages.eduvpn-client

GrahamcOfBorg · 2018-02-28T14:59:13Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘NetworkManager-openvpn-gnome-1.8.0’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/tools/networking/network-manager/openvpn.nix:38 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

GrahamcOfBorg · 2018-02-28T14:59:20Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: attribute 'eduvpn-client' in selection path 'pythonPackages.eduvpn-client' not found

GrahamcOfBorg · 2018-02-28T15:01:34Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

    return self.obtain(req, installer)
  File "/nix/store/h4gag637wxnip0wcfc4n2hngixq565sz-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1158, in obtain
    return installer(requirement)
  File "/nix/store/h4gag637wxnip0wcfc4n2hngixq565sz-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/setuptools/dist.py", line 528, in fetch_build_egg
    return cmd.easy_install(req)
  File "/nix/store/h4gag637wxnip0wcfc4n2hngixq565sz-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 667, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')
builder for ‘/nix/store/azi911lanamwcy1ai39j8zsgpyrrr7p6-eduvpn-client-1.0rc11.drv’ failed with exit code 1
error: build of ‘/nix/store/azi911lanamwcy1ai39j8zsgpyrrr7p6-eduvpn-client-1.0rc11.drv’ failed

GrahamcOfBorg · 2018-02-28T15:01:37Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘eduvpn-client’ in selection path ‘pythonPackages.eduvpn-client’ not found

GrahamcOfBorg · 2018-02-28T18:34:57Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m attribute 'eduvpn-client' in selection path 'pythonPackages.eduvpn-client' not found

GrahamcOfBorg · 2018-02-28T18:35:41Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

    return self.obtain(req, installer)
  File "/nix/store/grysm67ssvcr3irfwnbi1qhvs4929cl5-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/pkg_resources/__init__.py", line 1158, in obtain
    return installer(requirement)
  File "/nix/store/grysm67ssvcr3irfwnbi1qhvs4929cl5-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/setuptools/dist.py", line 528, in fetch_build_egg
    return cmd.easy_install(req)
  File "/nix/store/grysm67ssvcr3irfwnbi1qhvs4929cl5-python2.7-bootstrapped-pip-9.0.1/lib/python2.7/site-packages/setuptools/command/easy_install.py", line 667, in easy_install
    raise DistutilsError(msg)
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('pytest-runner')
builder for '/nix/store/xjjym671cnhsybhwmmgdh6ms49c9jaai-eduvpn-client-1.0rc11.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/xjjym671cnhsybhwmmgdh6ms49c9jaai-eduvpn-client-1.0rc11.drv' failed

Mic92 · 2018-02-28T23:18:51Z

pkgs/applications/networking/python-eduvpn-client/default.nix

+    pytest pytestrunner mock
+  ];
+
+  nativeBuildInputs = [ wrapGAppsHook ];


pytestrunner needs to be moved here.

reason: #36114 (comment)

pkgs/applications/networking/python-eduvpn-client/default.nix

pkgs/top-level/all-packages.nix

pkgs/applications/networking/python-eduvpn-client/default.nix

dotlambda · 2018-03-03T14:05:56Z

pkgs/top-level/python-packages.nix

@@ -21199,6 +21199,8 @@ EOF
    };
  };

+  eduvpn-client = callPackage ../applications/networking/python-eduvpn-client { };


If we want this to live inside pythonPackages, then default.nix would need to be moved to developments/python-modules/eduvpn-client and the python dependencies would have to be specified as arguments.
However, I think if the API is not used we shouldn't have it inside pythonPackages. The package supporting multiple python versions isn't an arguments because we can simply override pythonPackages = python3Packages.

@Mic92 What's your opinion?

@leenaars You would need to address this before the PR can be merged. Everything that belongs to python-packages.nix resides in development/python-modules, so you would need to move the expression to developments/python-modules/eduvpn-client as suggested above. Other option is to move eduvpn-client back to all-packages.nix and keep it at tools/networking/, that should be ok only if we assume that nobody is going to use the API from this package.

pkgs/tools/networking/python-eduvpn-client/default.nix

veprbl · 2018-12-05T17:18:21Z

pkgs/tools/networking/python-eduvpn-client/default.nix

+    requests_oauthlib six repoze_lru pillow qrcode pytestrunner
+    ];
+
+  # Checks need X environment


Providing a headless X11 environment shouldn't be a problem. For me it seems to require networkmanager first:

dbus.exceptions.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.NetworkManager was not provided by any .service files

veprbl · 2018-12-05T17:24:26Z

pkgs/tools/networking/python-eduvpn-client/default.nix

+      --replace "/usr/local" "$out"
+  '';
+
+  checkInputs = with pythonPackages; [ pytest mock pytestrunner ];


If we can't run tests, we don't need checkInputs.

pkgs/tools/networking/python-eduvpn-client/default.nix

FRidh

The location is still incorrect.

GrahamcOfBorg added 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 labels Feb 28, 2018

Mic92 reviewed Feb 28, 2018

View reviewed changes

leenaars force-pushed the eduvpn-client branch from 82f5894 to 7455839 Compare March 1, 2018 19:58

dotlambda requested changes Mar 2, 2018

View reviewed changes

dotlambda added the 6.topic: python label Mar 2, 2018

leenaars force-pushed the eduvpn-client branch from 7455839 to 4a88c35 Compare March 2, 2018 22:41

GrahamcOfBorg removed the 6.topic: python label Mar 2, 2018

leenaars force-pushed the eduvpn-client branch from 847518f to 2b50bb6 Compare March 2, 2018 22:50

dotlambda reviewed Mar 2, 2018

View reviewed changes

pkgs/applications/networking/python-eduvpn-client/default.nix Outdated Show resolved Hide resolved

pkgs/applications/networking/python-eduvpn-client/default.nix Outdated Show resolved Hide resolved

pkgs/applications/networking/python-eduvpn-client/default.nix Outdated Show resolved Hide resolved

dotlambda added the 6.topic: python label Mar 2, 2018

leenaars force-pushed the eduvpn-client branch from 2b50bb6 to b775546 Compare March 3, 2018 10:28

leenaars requested a review from FRidh as a code owner March 3, 2018 10:28

leenaars force-pushed the eduvpn-client branch from b775546 to 20f83d2 Compare March 3, 2018 13:32

dotlambda reviewed Mar 3, 2018

View reviewed changes

leenaars force-pushed the eduvpn-client branch from 20f83d2 to c67a51b Compare July 9, 2018 10:26

GrahamcOfBorg added the 2.status: merge conflict label Jul 9, 2018

leenaars force-pushed the eduvpn-client branch from c67a51b to 965b480 Compare August 1, 2018 00:29

GrahamcOfBorg removed 6.topic: python 2.status: merge conflict labels Aug 1, 2018

leenaars force-pushed the eduvpn-client branch from 965b480 to 2366f12 Compare August 1, 2018 00:37

GrahamcOfBorg added the 6.topic: python label Aug 1, 2018

leenaars changed the title ~~Eduvpn client: init at 1.0rc11~~ Eduvpn client: init at 1.0rc16 Aug 1, 2018

leenaars force-pushed the eduvpn-client branch from 2366f12 to 4b91930 Compare September 3, 2018 22:16

leenaars changed the title ~~Eduvpn client: init at 1.0rc16~~ Eduvpn client: init at 1.0.1 Sep 3, 2018

leenaars force-pushed the eduvpn-client branch 2 times, most recently from 8e0fb07 to e863977 Compare September 3, 2018 22:22

veprbl added the 2.status: merge conflict label Nov 28, 2018

veprbl reviewed Dec 5, 2018

View reviewed changes

pkgs/tools/networking/python-eduvpn-client/default.nix Outdated Show resolved Hide resolved

veprbl reviewed Dec 5, 2018

View reviewed changes

pkgs/tools/networking/python-eduvpn-client/default.nix Outdated Show resolved Hide resolved

eduvpn python client: init at 1.0.2

eb4f3d1

leenaars force-pushed the eduvpn-client branch from e863977 to eb4f3d1 Compare December 6, 2018 20:25

GrahamcOfBorg removed the 2.status: merge conflict label Dec 6, 2018

FRidh requested changes Jan 6, 2019

View reviewed changes

veprbl added the 9.needs: reporter feedback label Feb 26, 2019

leenaars closed this Apr 20, 2019

kilianar mentioned this pull request Jan 11, 2023

eduvpn-client: init at 3.1.0 #210180

Closed

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Eduvpn client: init at 1.0.1 #36122

Eduvpn client: init at 1.0.1 #36122

leenaars commented Feb 28, 2018 •

edited

Mic92 commented Feb 28, 2018

Mic92 commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

Mic92 Feb 28, 2018

Mic92 Feb 28, 2018

dotlambda Mar 3, 2018

dotlambda Mar 4, 2018

veprbl Dec 5, 2018

veprbl Dec 5, 2018

veprbl Dec 5, 2018

FRidh left a comment

Eduvpn client: init at 1.0.1 #36122

Eduvpn client: init at 1.0.1 #36122

Conversation

leenaars commented Feb 28, 2018 • edited

Motivation for this change

Things done

Mic92 commented Feb 28, 2018

Mic92 commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

Mic92 Feb 28, 2018

Choose a reason for hiding this comment

Mic92 Feb 28, 2018

Choose a reason for hiding this comment

dotlambda Mar 3, 2018

Choose a reason for hiding this comment

dotlambda Mar 4, 2018

Choose a reason for hiding this comment

veprbl Dec 5, 2018

Choose a reason for hiding this comment

veprbl Dec 5, 2018

Choose a reason for hiding this comment

veprbl Dec 5, 2018

Choose a reason for hiding this comment

FRidh left a comment

Choose a reason for hiding this comment

leenaars commented Feb 28, 2018 •

edited