bitcoin: 0.15.1 -> 0.16.0 #36121

roconnor · 2018-02-28T14:27:16Z

Bitcoin 0.16.0 now builds against the lastest Boost.

Motivation for this change

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Bitcoin 0.16.0 now builds against the lastest Boost.

Mic92 · 2018-02-28T14:28:46Z

@GrahamcOfBorg build bitcoin

GrahamcOfBorg · 2018-02-28T14:31:00Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

checking for miniupnpc/upnpcommands.h... yes
checking for main in -lminiupnpc... (cached) yes
checking miniupnpc/upnperrors.h usability... yes
checking miniupnpc/upnperrors.h presence... yes
checking for miniupnpc/upnperrors.h... yes
checking for main in -lminiupnpc... (cached) yes
checking for Qt5Core Qt5Gui Qt5Network Qt5Widgets... no
configure: error: Qt dependencies not found
builder for '/nix/store/l4l64vx9m952k6s3lkq6l89w8hga79qr-bitcoin-0.16.0.drv' failed with exit code 1
error: build of '/nix/store/l4l64vx9m952k6s3lkq6l89w8hga79qr-bitcoin-0.16.0.drv' failed

roconnor · 2018-02-28T14:37:52Z

@jb55 Would you like to review?

GrahamcOfBorg · 2018-02-28T14:59:23Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

libtool: warning: library '/nix/store/qbbvdpg81bp9lrmr35kl40vgb98iwahk-qtbase-5.10.1/lib/libQt5DBus.la' was moved.
libtool: warning: library '/nix/store/qbbvdpg81bp9lrmr35kl40vgb98iwahk-qtbase-5.10.1/lib/libQt5Core.la' was moved.
libtool: warning: library '/nix/store/qbbvdpg81bp9lrmr35kl40vgb98iwahk-qtbase-5.10.1/lib/libQt5Core.la' was moved.
  CXX      qt/test/qt_test_test_bitcoin_qt-compattests.o
  CXX      qt/test/qt_test_test_bitcoin_qt-rpcnestedtests.o
  CXX      qt/test/qt_test_test_bitcoin_qt-test_main.o
  CXX      qt/test/qt_test_test_bitcoin_qt-uritests.o
  CXX      test/qt_test_test_bitcoin_qt-test_bitcoin.o
building of ‘/nix/store/z9k7ch7wljp98ijv91xphps43aiha9br-bitcoin-0.16.0.drv’ timed out after 1800 seconds
error: build of ‘/nix/store/z9k7ch7wljp98ijv91xphps43aiha9br-bitcoin-0.16.0.drv’ failed

GrahamcOfBorg · 2018-02-28T15:08:23Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0/bin/test_bitcoin-qt
shrinking /nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0/bin/test_bitcoin
shrinking /nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0/lib  /nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0/bin 
patching script interpreter paths in /nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0
checking for references to /tmp/nix-build-bitcoin-0.16.0.drv-0 in /nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0...
postPatchMkspecs
/nix/store/5sz9s7147sj5ksrj0hbz6w0b3lzc1bv7-bitcoin-0.16.0

Mic92 · 2018-02-28T15:09:34Z

@GrahamcOfBorg build bitcoind

GrahamcOfBorg · 2018-02-28T15:09:47Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘bitcoind’ in selection path ‘bitcoind’ not found

GrahamcOfBorg · 2018-02-28T15:10:31Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: attribute 'bitcoind' in selection path 'bitcoind' not found

roconnor · 2018-02-28T15:21:11Z

@GrahamcOfBorg build altcoins.bitcoind

Mic92 · 2018-02-28T15:37:35Z

@GrahamcOfBorg build altcoins.bitcoind

GrahamcOfBorg · 2018-02-28T15:38:52Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

checking for exit in -lboost_filesystem... yes
checking whether the Boost::Program_Options library is available... yes
checking for exit in -lboost_program_options... yes
checking whether the Boost::Thread library is available... yes
checking for exit in -lboost_thread... yes
checking whether the Boost::Chrono library is available... yes
checking for exit in -lboost_chrono... yes
configure: error: hexdump is required for tests
builder for '/nix/store/w496gy6f7d7j366k4gnhd0jkcqlmq3sq-bitcoind-0.16.0.drv' failed with exit code 1
error: build of '/nix/store/w496gy6f7d7j366k4gnhd0jkcqlmq3sq-bitcoind-0.16.0.drv' failed

GrahamcOfBorg · 2018-02-28T15:46:11Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/bin/bitcoind
shrinking /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/bin/bench_bitcoin
shrinking /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/bin/test_bitcoin
shrinking /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/lib  /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/bin 
patching script interpreter paths in /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0
checking for references to /tmp/nix-build-bitcoind-0.16.0.drv-0 in /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0...
/nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0

Mic92 · 2018-02-28T16:08:47Z

it wants at least hexdump on macOS.

roconnor · 2018-02-28T16:40:30Z

Yes. Bitcoin has been broken on darwin for years. I'm waiting for a darwin enthusiast to propose a patch, but it seems there aren't any bitcoin-darwin-nix enthusiasts at the moment.

Maybe one day I can borrow a friend's OSX machine and figure out people build bitcoin on that platform.

Mic92 · 2018-02-28T16:44:08Z

Then it should be disabled at least on macOS.

GrahamcOfBorg · 2018-02-28T17:00:19Z

Success on x86_64-linux (full log)

Partial log (click to expand)

/nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0

jb55 · 2018-02-28T17:45:44Z

@roconnor sure, testing it now

jb55 · 2018-02-28T18:28:42Z

Tested ACK 2d102cb

GrahamcOfBorg · 2018-02-28T18:35:00Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m attribute 'bitcoind' in selection path 'bitcoind' not found

roconnor · 2018-02-28T19:23:06Z

@Mic92 How to disable darwin? A cursory pass through the nixpkgs manual didn't reveal anything to me.

GrahamcOfBorg · 2018-02-28T19:33:53Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

  CXX      libbitcoin_server_a-addrdb.o
  CXX      libbitcoin_server_a-addrman.o
  CXX      libbitcoin_server_a-bloom.o
  CXX      libbitcoin_server_a-blockencodings.o
  CXX      libbitcoin_server_a-chain.o
  CXX      libbitcoin_server_a-checkpoints.o
  CXX      consensus/libbitcoin_server_a-tx_verify.o
  CXX      libbitcoin_server_a-httprpc.o
building of '/nix/store/6ylmqf9qn4r1gzdi8lk4411qbn3vgjg4-bitcoin-0.16.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/6ylmqf9qn4r1gzdi8lk4411qbn3vgjg4-bitcoin-0.16.0.drv' failed

GrahamcOfBorg · 2018-02-28T19:35:18Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

  CXX      libbitcoin_server_a-net.o
  CXX      libbitcoin_server_a-net_processing.o
  CXX      libbitcoin_server_a-noui.o
  CXX      policy/libbitcoin_server_a-fees.o
  CXX      policy/libbitcoin_server_a-policy.o
  CXX      policy/libbitcoin_server_a-rbf.o
  CXX      libbitcoin_server_a-pow.o
  CXX      libbitcoin_server_a-rest.o
building of '/nix/store/fahgs13jyam3bbcmkgld52b5224g4sf9-bitcoind-0.16.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/fahgs13jyam3bbcmkgld52b5224g4sf9-bitcoind-0.16.0.drv' failed

GrahamcOfBorg · 2018-02-28T20:33:54Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

gcc gen_context.o -o gen_context
./gen_context
  CC       src/libsecp256k1_la-secp256k1.lo
  CCLD     libsecp256k1.la
/nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/ar: `u' modifier ignored since `D' is the default (see `U')
make[3]: Leaving directory '/build/bitcoin-0.16.0/src/secp256k1'
  CXXLD    libbitcoinconsensus.la
  CXX      bitcoind-bitcoind.o
building of '/nix/store/6ylmqf9qn4r1gzdi8lk4411qbn3vgjg4-bitcoin-0.16.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/6ylmqf9qn4r1gzdi8lk4411qbn3vgjg4-bitcoin-0.16.0.drv' failed

GrahamcOfBorg · 2018-02-28T20:35:25Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

  CXX      libbitcoin_server_a-bloom.o
  CXX      libbitcoin_server_a-blockencodings.o
  CXX      libbitcoin_server_a-chain.o
  CXX      libbitcoin_server_a-checkpoints.o
  CXX      consensus/libbitcoin_server_a-tx_verify.o
  CXX      libbitcoin_server_a-httprpc.o
  CXX      libbitcoin_server_a-httpserver.o
  CXX      libbitcoin_server_a-init.o
building of '/nix/store/fahgs13jyam3bbcmkgld52b5224g4sf9-bitcoind-0.16.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/fahgs13jyam3bbcmkgld52b5224g4sf9-bitcoind-0.16.0.drv' failed

Mic92 · 2018-03-01T13:58:28Z

@roconnor for example by changing meta.platforms = platforms.unix; to platforms = platforms.linux;.

roconnor · 2018-03-01T14:05:36Z

Thanks. I'll look into it.

FWIW, I think #25188 could provide a solution to this problem if implemented.

Mic92 · 2018-03-01T14:06:40Z

@roconnor in future maybe.

roconnor · 2018-03-01T14:26:58Z

@Mic92 Okay, I've added a dependency on darwin.shell_cmds. I think this actually may fix the build on darwin but I don't have a machine to test it on. Maybe we can try GrahamcOfBorg?

If it fails, I'll revert and change the meta.platforms instead.

Mic92 · 2018-03-01T14:55:38Z

@GrahamcOfBorg build altcoins.bitcoind

GrahamcOfBorg · 2018-03-01T14:56:20Z

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Try '/nix/store/h4i092yq3v0dh48g3flj5nvyh27sdw6a-bison-3.0.4/bin/bison --help' for more information.

** BUILD FAILED **

The following build commands failed:

(1 failure)
builder for '/nix/store/zgm4av2j3ypbavpqwnq630macpc63jf1-shell_cmds-osx-10.11.6.drv' failed with exit code 1
cannot build derivation '/nix/store/s5d9cl3bgj2l688f9blnvdqh6xh16zan-bitcoind-0.16.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/s5d9cl3bgj2l688f9blnvdqh6xh16zan-bitcoind-0.16.0.drv' failed

Mic92 · 2018-03-01T15:00:02Z

@LnL7 out of general interest by looking at the error message, does bison in nixpkgs comes from GNU or from macOS?

roconnor · 2018-03-01T15:10:04Z

I see, darwin.shell_cmds doesn't even build. I guess this is too far out of my league. I'll disable darwin builds.

GrahamcOfBorg · 2018-03-01T15:19:55Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/bin/bitcoin-tx
shrinking /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/bin/bitcoind
shrinking /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/bin/bench_bitcoin
shrinking /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/lib  /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0/bin 
patching script interpreter paths in /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0
checking for references to /tmp/nix-build-bitcoind-0.16.0.drv-0 in /nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0...
/nix/store/bfqwgvk44b89cf2x7nfswgp9q4pn50xj-bitcoind-0.16.0

GrahamcOfBorg · 2018-03-01T15:31:35Z

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0/bin/test_bitcoin-qt
shrinking /nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0/bin/test_bitcoin
shrinking /nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0/lib/libbitcoinconsensus.so.0.0.0
gzipping man pages under /nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0/lib  /nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0/bin 
patching script interpreter paths in /nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0
checking for references to /tmp/nix-build-bitcoin-0.16.0.drv-0 in /nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0...
postPatchMkspecs
/nix/store/a848mzv0m2fh60p06yjnc0jd4kah9nh1-bitcoin-0.16.0

GrahamcOfBorg · 2018-03-01T15:37:00Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

  CXX      rpc/libbitcoin_server_a-rawtransaction.o
  CXX      rpc/libbitcoin_server_a-safemode.o
  CXX      rpc/libbitcoin_server_a-server.o
  CXX      script/libbitcoin_server_a-sigcache.o
  CXX      script/libbitcoin_server_a-ismine.o
  CXX      libbitcoin_server_a-timedata.o
  CXX      libbitcoin_server_a-torcontrol.o
  CXX      libbitcoin_server_a-txdb.o
building of '/nix/store/92k2yrv1rb32r4yjhya8ndgdlybwmf36-bitcoin-0.16.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/92k2yrv1rb32r4yjhya8ndgdlybwmf36-bitcoin-0.16.0.drv' failed

GrahamcOfBorg · 2018-03-01T15:56:27Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

  CXX      rpc/libbitcoin_util_a-util.o
  CXX      support/libbitcoin_util_a-cleanse.o
  CXX      libbitcoin_util_a-sync.o
  CXX      libbitcoin_util_a-threadinterrupt.o
  CXX      libbitcoin_util_a-util.o
  CXX      libbitcoin_util_a-utilmoneystr.o
  CXX      libbitcoin_util_a-utilstrencodings.o
  CXX      libbitcoin_util_a-utiltime.o
building of '/nix/store/fahgs13jyam3bbcmkgld52b5224g4sf9-bitcoind-0.16.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/fahgs13jyam3bbcmkgld52b5224g4sf9-bitcoind-0.16.0.drv' failed

bitcoin requires hexdump to build. In theory hexdump is provided by the darwin.shell_cmds, but that packages doesn't seem to build at the moment.

roconnor · 2018-03-01T16:33:11Z

@Mic92 Darwin builds should be disabled now. Please merge when you are satisfied.

GrahamcOfBorg · 2018-03-01T17:01:44Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

  CXX      qt/qt_libbitcoinqt_a-moc_signverifymessagedialog.o
  GEN      qt/moc_splashscreen.cpp
  CXX      qt/qt_libbitcoinqt_a-moc_splashscreen.o
  GEN      qt/moc_trafficgraphwidget.cpp
  CXX      qt/qt_libbitcoinqt_a-moc_trafficgraphwidget.o
  GEN      qt/moc_transactiondesc.cpp
  CXX      qt/qt_libbitcoinqt_a-moc_transactiondesc.o
  GEN      qt/moc_transactiondescdialog.cpp
building of ‘/nix/store/6n4w499lf70v4kv4lmi74b9yh7pzvaqx-bitcoin-0.16.0.drv’ timed out after 1800 seconds
error: build of ‘/nix/store/6n4w499lf70v4kv4lmi74b9yh7pzvaqx-bitcoin-0.16.0.drv’ failed

GrahamcOfBorg · 2018-03-01T17:32:00Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

  CXX      libbitcoin_server_a-net.o
  CXX      libbitcoin_server_a-net_processing.o
  CXX      libbitcoin_server_a-noui.o
  CXX      policy/libbitcoin_server_a-fees.o
  CXX      policy/libbitcoin_server_a-policy.o
  CXX      policy/libbitcoin_server_a-rbf.o
  CXX      libbitcoin_server_a-pow.o
  CXX      libbitcoin_server_a-rest.o
building of '/nix/store/92k2yrv1rb32r4yjhya8ndgdlybwmf36-bitcoin-0.16.0.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/92k2yrv1rb32r4yjhya8ndgdlybwmf36-bitcoin-0.16.0.drv' failed

LnL7 · 2018-03-01T20:59:26Z

@Mic92 We don't have a separate version of bison as far as I know.

bitcoin: 0.15.1 -> 0.16.0

2d102cb

Bitcoin 0.16.0 now builds against the lastest Boost.

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 28, 2018

bitcoin: Disable darwin builds

1759eec

bitcoin requires hexdump to build. In theory hexdump is provided by the darwin.shell_cmds, but that packages doesn't seem to build at the moment.

roconnor force-pushed the bitcoin branch from 4606add to 1759eec Compare March 1, 2018 16:23

GrahamcOfBorg added 8.has: clean-up 10.rebuild-darwin: 0 and removed 10.rebuild-darwin: 1-10 labels Mar 1, 2018

Mic92 merged commit 4bb17f5 into NixOS:master Mar 2, 2018

bitcoin: 0.15.1 -> 0.16.0 #36121

bitcoin: 0.15.1 -> 0.16.0 #36121

Conversation

roconnor commented Feb 28, 2018

Motivation for this change

Things done

Mic92 commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

roconnor commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

Mic92 commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

roconnor commented Feb 28, 2018

Mic92 commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

Mic92 commented Feb 28, 2018

roconnor commented Feb 28, 2018

Mic92 commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

jb55 commented Feb 28, 2018

jb55 commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

roconnor commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

GrahamcOfBorg commented Feb 28, 2018

Mic92 commented Mar 1, 2018

roconnor commented Mar 1, 2018

Mic92 commented Mar 1, 2018

roconnor commented Mar 1, 2018

Mic92 commented Mar 1, 2018

GrahamcOfBorg commented Mar 1, 2018

Mic92 commented Mar 1, 2018

roconnor commented Mar 1, 2018

GrahamcOfBorg commented Mar 1, 2018

GrahamcOfBorg commented Mar 1, 2018

GrahamcOfBorg commented Mar 1, 2018

GrahamcOfBorg commented Mar 1, 2018

roconnor commented Mar 1, 2018

GrahamcOfBorg commented Mar 1, 2018

GrahamcOfBorg commented Mar 1, 2018

LnL7 commented Mar 1, 2018