Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rtlwifi: 2017-07-18 -> 2018-02-17 #36128

Merged
merged 1 commit into from Mar 1, 2018
Merged

rtlwifi: 2017-07-18 -> 2018-02-17 #36128

merged 1 commit into from Mar 1, 2018

Conversation

georgewhewell
Copy link
Contributor

Motivation for this change

rtlwifi_new does not build on kernel > 4.15, update to a version that does

Things done

tested build (but not boot) with:

nix-shell -p linuxPackages_4_4.rtlwifi_new
nix-shell -p linuxPackages_4_9.rtlwifi_new
nix-shell -p linuxPackages_latest.rtlwifi_new

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Feb 28, 2018

@GrahamcOfBorg build linuxPackages_latest.rtlwifi_new linuxPackages_4_9.rtlwifi_new linuxPackages_4_4.rtlwifi_new

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13287:19:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/rtlwifi_new/default.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
while evaluating the attribute 'linux_4_15' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13151:3:
while evaluating 'callPackageWith' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:113:35, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/top-level/all-packages.nix:13151:16:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:117:8:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.15.nix:1:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
while evaluating 'makeOverridable' at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:72:24, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/linux-4.15.nix:5:1:
while evaluating anonymous function at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:9:1, called from /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/lib/customisation.nix:74:12:
assertion failed at /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/os-specific/linux/kernel/generic.nix:41:1

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_stats.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_dcb.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sp.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_vfpf.o
  CC [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.o
  LD [M]  drivers/net/ethernet/broadcom/bnx2x/bnx2x.o
  CC [M]  drivers/net/ethernet/broadcom/bnxt/bnxt.o
building of ‘/nix/store/sf2ms0kqnd98c565r6mkk3a8i116jznv-linux-4.15.7.drv’ timed out after 3600 seconds
cannot build derivation ‘/nix/store/lbr5s5zbya86k2c15wl299dlclfs85pd-rtlwifi_new-2018-02-17.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/5skdhacnfr3960xllkffc1hidacimdmd-rtlwifi_new-2018-02-17.drv’, ‘/nix/store/6pbgq0jac543y1pal6hlg896cx4akm3f-rtlwifi_new-2018-02-17.drv’, ‘/nix/store/lbr5s5zbya86k2c15wl299dlclfs85pd-rtlwifi_new-2018-02-17.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

  CC [M]  sound/hda/hdac_regmap.o
  LD [M]  sound/i2c/other/snd-ak4114.o
  CC      ipc/msg.o
  CC      drivers/clocksource/rockchip_timer.o
  LD [M]  sound/i2c/other/snd-ak4113.o
  CC [M]  drivers/fmc/fmc-dump.o
building of '/nix/store/6axm1ansasm04bbadgjbdxa1dd0fbbq3-linux-4.15.7.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/1aprpkahsjhraj9fgap5syywz033gw1p-rtlwifi_new-2018-02-17.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y9fw5j0wg3dfjb1v7l5m3i4n6pmgv7ky-rtlwifi_new-2018-02-17.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/1aprpkahsjhraj9fgap5syywz033gw1p-rtlwifi_new-2018-02-17.drv', '/nix/store/8rpm4sxzfp1sxashwr3c67a19fb61vd4-rtlwifi_new-2018-02-17.drv', '/nix/store/y9fw5j0wg3dfjb1v7l5m3i4n6pmgv7ky-rtlwifi_new-2018-02-17.drv' failed

@Mic92
Copy link
Member

Mic92 commented Mar 1, 2018

builds for me:

$ echo $buildInputs
/nix/store/5p03377m6m3kkdf06k98mr2r9szmi698-rtlwifi_new-2018-02-17 /nix/store/p6nnizgm1zyg7k5k7brc4sd593jxak60-rtlwifi_new-2018-02-17 /nix/store/1mhpbqlf1sb91i0pi8wprv4cj6mrw21f-rtlwifi_new-2018-02-17 /nix/store/x3zbjkqp6m3g98vshszslb47f2gsvqsf-rtlwifi_new-firmware-2018-02-17 /nix/store/5c9v13dg9aali5fpxcipyhnd85wbbdx2-rtlwifi_new-2018-02-17 /nix/store/8mca6hqsd93nprm8hzhbw9zykd6vgl9n-rtlwifi_new-2018-02-17 /nix/store/f3ijq8zg4yhxkgm6lfl8i1b2z2wyl1d8-rtlwifi_new-2018-02-17 /nix/store/8h6plhcrd0cfk88n3lbn1c7xvazz25d4-rtlwifi_new-2018-02-17 /nix/store/91hypkwi9ic1m1dnmxkv797j43bx2ygb-rtlwifi_new-2018-02-17 /nix/store/345h2qjsyzdq8srdczc05qzf25avcr1f-rtlwifi_new-2018-02-17 /nix/store/zgbj2wqjd190fhvfb0svvqbah1x1cj2c-rtlwifi_new-2018-02-17 /nix/store/1bjb3mbcdcn8ibda8180c59l3yrr0xv8-rtlwifi_new-2018-02-17 /nix/store/c87brsd03pc330vl7i5clxg4fya2g9w3-rtlwifi_new-2018-02-17 /nix/store/6bzm8m2pkbbjqv8var2zk23yw0639axk-rtlwifi_new-2018-02-17

@Mic92 Mic92 merged commit b62a26e into NixOS:master Mar 1, 2018
@georgewhewell georgewhewell deleted the rtlwifi branch March 1, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@georgewhewell @Mic92 @GrahamcOfBorg