apulse: 0.1.10 -> 0.1.11, add pressureaudio #35076
Conversation
|
I tested |
|
Firefox 58 is mentioned on the |
|
Ah, thanks! |
pkgs/misc/apulse/pressureaudio.nix
Outdated
| ''; | ||
|
|
||
| installPhase = '' | ||
| echo "Coping libraries." |
There was a problem hiding this comment.
Either use : for empty phases and reduce verbosity here, or fix the typo: ‘‘Coping’’ → ‘‘Copying’’
pkgs/misc/apulse/pressureaudio.nix
Outdated
| echo "Coping libraries." | ||
| mkdir -p $out/lib | ||
| ls ${apulse}/lib/apulse $out/lib | ||
| cp -a ${apulse}/lib/apulse/* $out/lib/ |
There was a problem hiding this comment.
Any reason for cp -a instead of ln -s?
pkgs/misc/apulse/pressureaudio.nix
Outdated
| But apulse is made to be used as a wrapper that substitutes its | ||
| replacement libs into LD_LIBRARY_PATH. The problem with that is | ||
| that you have to link against the original libpulseaudio, which | ||
| means you have to build it (and risk executing it eventually). |
There was a problem hiding this comment.
Maybe remove this paragraph (and the last one)? As it is, libpulseaudio packages in Nix does not build any executables, and I am not sure there are any risks in failed attempts to connect by PA client library.
|
Either use `:` for empty phases and reduce verbosity here, or fix the typo: ‘‘Coping’’ → ‘‘Copying’’
Oops, that and the correct .pc files were lost in the git stash. Fixed. Thanks.
Any reason for `cp -a` instead of `ln -s`?
I tried, but it gets ugly fast as the original has symlinks you have to
preserve too. It's gonna be rehardlinked by nix-store store optimization
anyway. (Header files too, btw.)
Maybe remove this paragraph (and the last one)? As it is, `libpulseaudio` packages in Nix does not build any executables, and I am not sure there are any risks in failed attempts to connect by PA client library.
Fixed.
|
Motivation for this change
Living without PulseAudio.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)