nixos/networking: start dhcpcd even when defaultGateway6 is set #35064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abbradar
reviewed
Feb 19, 2018
| @@ -155,8 +155,7 @@ in | |||
|
|
|||
| systemd.services.dhcpcd = let | |||
| cfgN = config.networking; | |||
| hasDefaultGatewaySet = (cfgN.defaultGateway != null && cfgN.defaultGateway.address != "") | |||
| || (cfgN.defaultGateway6 != null && cfgN.defaultGateway6.address != ""); | |||
| hasDefaultGatewaySet = (cfgN.defaultGateway != null && cfgN.defaultGateway.address != ""); | |||
There was a problem hiding this comment.
That this is invalid too -- this would prevent starting dhcpcd for resolving IPv6 addresses before declaring a network online if IPv4 gateway is set. We probably want network-online.target to signify that both stacks are ready.
There was a problem hiding this comment.
Nope, you actually have an advantage of yours: you also fix hasDefaultGatewaySet in network-interface-scripted.nix which I didn't know was there :3 I think it's better to unify those as a hidden NixOS option...
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fix #34716
Things done