Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwupd: 1.0.5 update & cleanups #35065

Merged
merged 7 commits into from Feb 23, 2018
Merged

fwupd: 1.0.5 update & cleanups #35065

merged 7 commits into from Feb 23, 2018

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Feb 17, 2018

Motivation for this change

Update fwupd, fwupdate, libsmbios and umockdev; clean up #35011, fix #32142, #35072, re-enable test.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.4.1’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/os-specific/linux/libsmbios/default.nix:32 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘efibootmgr-15’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/system/efibootmgr/default.nix:23 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

checking for references to /tmp/nix-build-fwupd-1.0.5.drv-0 in /nix/store/5j3gf2h55xikhdib81j5iaakgk6w3asa-fwupd-1.0.5-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/j49ks5jaw0fkbn6kl9yfa0ml98j77cnz-fwupd-1.0.5-installedTests
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/j49ks5jaw0fkbn6kl9yfa0ml98j77cnz-fwupd-1.0.5-installedTests
checking for references to /tmp/nix-build-fwupd-1.0.5.drv-0 in /nix/store/j49ks5jaw0fkbn6kl9yfa0ml98j77cnz-fwupd-1.0.5-installedTests...
/nix/store/qa52v65499jq372fl3y5nc0768kw7dw4-efibootmgr-15
/nix/store/ipfwvqjqgllvv0cnkj7jsbiw4ql1dixf-fwupd-1.0.5
/nix/store/hkw69gi94wq50adlpdyqi63iiy5wyk9q-fwupdate-10
/nix/store/9dmxfskraszbg748bzc3rsz9ibff4rlj-libsmbios-2.4.1
/nix/store/jxw5md5vdk68iiqzswgnr48d1w6q6jd3-umockdev

@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 17, 2018

@GrahamcOfBorg test fwupd

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.4.1’ in /var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/os-specific/linux/libsmbios/default.nix:32 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

cannot build derivation '/nix/store/8vg4ywziimzq4cx2j55qfmdr5l8qsi83-system-units.drv': 5 dependencies couldn't be built
cannot build derivation '/nix/store/ifgcaszv0bzwx44q41rry2sxgq7b4x1f-user-units.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/m9ybxky5195id7dq9943vilzlam4x2w3-etc.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/gl8x3vhvzfz78lg8d18im0g5k6d29qpl-nixos-system-machine-18.03.git.035a039.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/xnbvmlnplxarfac5awfz6ry5l4nx2lfb-closure-info.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5534fyn0h97n7v79y2jbvf8s52yymh2j-run-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/k1r3gkrlv9ka6plpgysfk18993lbjjb4-nixos-vm.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/sr01m4zmh2bigdxdk802fii4h0w9f9xi-nixos-test-driver-fwupd.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/zvfswpnk6h1plqmrl25ayqaj4yhx91vf-vm-test-run-fwupd.drv': 1 dependencies couldn't be built
error: build of '/nix/store/zvfswpnk6h1plqmrl25ayqaj4yhx91vf-vm-test-run-fwupd.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘efibootmgr-15’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/system/efibootmgr/default.nix:23 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

11/11 synapticsmst-self-test                  OK       0.01 s

OK:        10
FAIL:       1
SKIP:       0
TIMEOUT:    0

Full log written to /build/fwupd-1.0.5/build/meson-logs/testlog.txt
builder for '/nix/store/a576dhlyl2fqc57gx49bl3yqvrw9sf3j-fwupd-1.0.5.drv' failed with exit code 1
error: build of '/nix/store/a576dhlyl2fqc57gx49bl3yqvrw9sf3j-fwupd-1.0.5.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘efibootmgr-15’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/system/efibootmgr/default.nix:23 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.4.1’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/os-specific/linux/libsmbios/default.nix:32 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘efibootmgr-15’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/system/efibootmgr/default.nix:23 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.4.1’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/os-specific/linux/libsmbios/default.nix:32 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

checking for references to /tmp/nix-build-fwupd-1.0.5.drv-0 in /nix/store/xz62a9z3in94h2casdyx35srgs31mrw1-fwupd-1.0.5-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/81cy44msf0j879gc1b0dlgs2sg4h1fd5-fwupd-1.0.5-installedTests
strip is /nix/store/adidfx4pa7vmvby0gjqqmiwg2x49yr27-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/81cy44msf0j879gc1b0dlgs2sg4h1fd5-fwupd-1.0.5-installedTests
checking for references to /tmp/nix-build-fwupd-1.0.5.drv-0 in /nix/store/81cy44msf0j879gc1b0dlgs2sg4h1fd5-fwupd-1.0.5-installedTests...
/nix/store/qa52v65499jq372fl3y5nc0768kw7dw4-efibootmgr-15
/nix/store/yr2iaj97sh1xndj4y47nyg7ipr0v1kb4-fwupd-1.0.5
/nix/store/hkw69gi94wq50adlpdyqi63iiy5wyk9q-fwupdate-10
/nix/store/9dmxfskraszbg748bzc3rsz9ibff4rlj-libsmbios-2.4.1
/nix/store/jxw5md5vdk68iiqzswgnr48d1w6q6jd3-umockdev

@jtojnar
Copy link
Contributor Author

jtojnar commented Feb 18, 2018

@GrahamcOfBorg test fwupd

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

Package ‘libsmbios-2.4.1’ in /var/lib/gc-of-borg/nix-test-rs-3/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-3/pkgs/os-specific/linux/libsmbios/default.nix:32 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@NixOS NixOS deleted a comment from GrahamcOfBorg Apr 14, 2018
@Moredread
Copy link
Contributor

Moredread commented Apr 30, 2018

When mounting the boot partition with full permissions (i.e. mount flags 'fmask=0000,dmask=0000') it works. :)

I overlooked that before, as I only tried chmod-ing the EFI directories. I guess that doesn't work correctly with a vfat filesystem?

Does someone know under which user the fwupd process is executed?

@jtojnar
Copy link
Contributor Author

jtojnar commented Apr 30, 2018

It runs as root on my system.

@abrooks
Copy link

abrooks commented May 31, 2018

Is this issue sufficiently fixed? Is it ready to be merged in to master? Is there anything I can do to help move it along?

@jtojnar
Copy link
Contributor Author

jtojnar commented May 31, 2018

@abrooks follow #39386 and #39792

@abrooks
Copy link

abrooks commented Jun 5, 2018

@jtojnar I was following #39386 but missed #39792. Thanks for pointing me to that PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nixos/fwupd: prevent build during evaluation
5 participants