Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcl/tk: 8.6.6 -> 8.6.8 and create library symlink #35069

Closed
wants to merge 1 commit into from
Closed

tcl/tk: 8.6.6 -> 8.6.8 and create library symlink #35069

wants to merge 1 commit into from

Conversation

NickHu
Copy link
Contributor

@NickHu NickHu commented Feb 17, 2018

tcl/tk were out of date. Also, I tried to compile something with gcc -ltcl -ltk and it complained about not being able to find those libraries - turns
out, the symlinks for them are never made, so I had to use gcc -ltcl8.6 -ltk8.6. Most distros make these themselves, so I added another line.

There seems to be some oddness with the sha256 sum - the package built
successfully even when I forgot to update it (it's up to date in this commit); I
don't know what's going on here, but someone more experienced than me should
probably check it out.

I also enabled the --enable-64bit flag; this is probably not contentious, I
just saw that other distros were doing it too.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@samueldr
Copy link
Member

I'll try to get things moving a bit.

First off, built on top of current nixpkgs-unstable, gitk starts up, which I'll assume is a trivial tcl/tk package (now knowing much about tcl/tk).

image

Verified using env -i NIXPKGS_ALLOW_UNFREE=1 nix-build -A gitAndTools.gitFull, let's see what the CI thinks about that.

@GrahamcOfBorg build gitAndTools.gitFull

Also if you have any ideas of other tcl/tk, especially fiddly or non-trivial ones to test this on, I'm all ears.

There were questions about --enable-64bit which was added, looks like nix-build -A pkgsi686Linux.gitAndTools.gitFull built fine here.

@GrahamcOfBorg
Copy link

Timed out, unknown build status on x86_64-darwin (full log)

Attempted: gitAndTools.gitFull

Partial log (click to expand)

t4129-apply-samemode.sh ............................ ok
t4130-apply-criss-cross-rename.sh .................. ok
t4131-apply-fake-ancestor.sh ....................... ok
t4132-apply-removal.sh ............................. ok
t4133-apply-filenames.sh ........................... ok
t4134-apply-submodule.sh ........................... ok
t4135-apply-weird-filenames.sh ..................... ok
t4136-apply-check.sh ............................... ok
building of '/nix/store/hyvfm248d5wdh3f39z4xm26ks1w8ly75-git-2.18.0.drv' timed out after 1200 seconds
error: build of '/nix/store/hyvfm248d5wdh3f39z4xm26ks1w8ly75-git-2.18.0.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitAndTools.gitFull

Partial log (click to expand)

All tests successful.
Files=816, Tests=19219, 124 wallclock secs ( 6.83 usr  1.23 sys + 332.81 cusr 343.60 csys = 684.47 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.18.0/t'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.18.0/t'
make[1]: Leaving directory '/build/git-2.18.0/t'
/nix/store/nxl6dsxqs3hi7qvp9b362a3is5zgwjip-git-2.18.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitAndTools.gitFull

Partial log (click to expand)

All tests successful.
Files=816, Tests=19219, 272 wallclock secs (83.74 usr 19.57 sys + 2920.97 cusr 7904.14 csys = 10928.42 CPU)
Result: PASS
make clean-except-prove-cache
make[2]: Entering directory '/build/git-2.18.0/t'
rm -f -r 'trash directory'.* 'test-results'
rm -f -r valgrind/bin
make[2]: Leaving directory '/build/git-2.18.0/t'
make[1]: Leaving directory '/build/git-2.18.0/t'
/nix/store/v6s3w8xari9706glbdkyiyx64ykf53by-git-2.18.0

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 21, 2018

@GrahamcOfBorg build tcl tk scid-vs-pc

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tcl, tk, scid-vs-pc

Partial log (click to expand)

shrinking /nix/store/9nhw43qxvzkwb8nvbq9520jn4jz0biyl-scid-vs-pc-4.18.1/bin/fruit
shrinking /nix/store/9nhw43qxvzkwb8nvbq9520jn4jz0biyl-scid-vs-pc-4.18.1/bin/phalanx
shrinking /nix/store/9nhw43qxvzkwb8nvbq9520jn4jz0biyl-scid-vs-pc-4.18.1/bin/scidt
shrinking /nix/store/9nhw43qxvzkwb8nvbq9520jn4jz0biyl-scid-vs-pc-4.18.1/bin/tcscid
strip is /nix/store/vcc4svb8gy29g4pam2zja6llkbcwsyiq-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/9nhw43qxvzkwb8nvbq9520jn4jz0biyl-scid-vs-pc-4.18.1/bin
checking for references to /build in /nix/store/9nhw43qxvzkwb8nvbq9520jn4jz0biyl-scid-vs-pc-4.18.1...
/nix/store/mxsabdkjdbdanbh848w3a2sijrvpcsb3-tcl-8.6.8
/nix/store/45c4rdjbrp3c93vck8sk9d4y708nl5k8-tk-8.6.8
/nix/store/9nhw43qxvzkwb8nvbq9520jn4jz0biyl-scid-vs-pc-4.18.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: tcl, tk, scid-vs-pc

Partial log (click to expand)

shrinking /nix/store/zws0vgzca4abn7r5d09kqz5g0nmyic1q-scid-vs-pc-4.18.1/bin/scmerge
shrinking /nix/store/zws0vgzca4abn7r5d09kqz5g0nmyic1q-scid-vs-pc-4.18.1/bin/tcscid
shrinking /nix/store/zws0vgzca4abn7r5d09kqz5g0nmyic1q-scid-vs-pc-4.18.1/bin/tkscid
shrinking /nix/store/zws0vgzca4abn7r5d09kqz5g0nmyic1q-scid-vs-pc-4.18.1/bin/pgnscid
strip is /nix/store/p9akxn2sfy4wkhqdqa3li97pc6jaz3r1-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zws0vgzca4abn7r5d09kqz5g0nmyic1q-scid-vs-pc-4.18.1/bin
checking for references to /build in /nix/store/zws0vgzca4abn7r5d09kqz5g0nmyic1q-scid-vs-pc-4.18.1...
/nix/store/m21y13vl4xrss8lk85c70rh1xl6r452c-tcl-8.6.8
/nix/store/5ypfhl04f8qzfhdcaddi2mak7wi3vrf5-tk-8.6.8
/nix/store/zws0vgzca4abn7r5d09kqz5g0nmyic1q-scid-vs-pc-4.18.1

@c0bw3b c0bw3b added this to the 19.03 milestone Nov 1, 2018
@bobvanderlinden
Copy link
Member

bobvanderlinden commented Apr 13, 2019 •
edited

This package seems ready to be merged apart from the conflicting file?

EDIT: I see that there now already is a 64bit option available: https://github.com/nixos/nixpkgs/blob/969149302c3ad1a0fddcb19811ac674ebbbfe676/pkgs/development/interpreters/tcl/generic.nix#L29

This PR is not needed anymore, apart from the version bump. Should the version bump be based on staging or master?

Should this PR be closed?

@lightbulbjim
Copy link
Contributor

Conflict aside, 8.6.9 has since been released so this PR is obsolete. Agree that it should be closed.

@c0bw3b c0bw3b removed this from the 19.03 milestone Apr 22, 2019
@c0bw3b c0bw3b mentioned this pull request Apr 22, 2019
Closed
10 tasks
@c0bw3b c0bw3b closed this Apr 22, 2019
@c0bw3b c0bw3b mentioned this pull request Apr 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@NickHu @samueldr @GrahamcOfBorg @c0bw3b @bobvanderlinden @lightbulbjim @infinisil