avidemux: rewrite derivation #35080
Merged
avidemux: rewrite derivation #35080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drastically reduces the complexity of the `avidemux` derivation and adds QT5 support (see NixOS#33248). Rather than invoking `cmake` over preconfigured hooks, it's much easier to use the `bootStrap.bash` script provided by the developers to do the installation tasks. Furthermore this script makes it way easier to configure which parts of `avidemux` should be used (e.g. CLI-only) or without the plugins. In order to create a CLI-only instance you can simply override the derivation: ``` avidemux.override { withQT = false; } ``` It's possible to set the default executable as well (`avidemux` creates a `avidemux_qt5` and `avidemux_cli` executable by default): ``` avidemux.override { default = "cli"; # default is `qt5` } ``` The GTK support has been dropped entirely since it was originally broken in our system and can't be built ATM. Other distros such as ArchLinux don't support GTK anymore (see https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/avidemux#n64)
Ma27
commented
Feb 17, 2018
| meta = with stdenv.lib; { | ||
| homepage = http://fixounet.free.fr/avidemux/; | ||
| description = "Free video editor designed for simple video editing tasks"; | ||
| maintainers = with maintainers; [ viric abbradar ma27 ]; |
|
My original motivation for this complexity was to split Avidemux over several derivations so that one can build GTK and Qt plugins separately from core libraries. However given that there is only one backend now which people would likely use (Qt 5) it doesn't seem to worth it now. Thanks! P.S.: I'm okay with keeping me as a maintainer. |
|
great @abbradar . |
|
@Ma27 Nope, I'll test and merge if everything is okay today. Thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This drastically reduces the complexity of the
avidemuxderivationand adds QT5 support (see #33248).
Rather than invoking
cmakeover preconfigured hooks, it's much easierto use the
bootStrap.bashscript provided by the developers to do theinstallation tasks. Furthermore this script makes it way easier to
configure which parts of
avidemuxshould be used (e.g. CLI-only) orwithout the plugins.
In order to create a CLI-only instance you can simply override the
derivation:
It's possible to set the default executable as well (
avidemuxcreatesa
avidemux_qt5andavidemux_cliexecutable by default):The GTK support has been dropped entirely since it was originally broken
in our system and can't be built ATM. Other distros such as ArchLinux
don't support GTK anymore (see https://git.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/avidemux#n64)
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)