Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt5X.full: add missing modules #35070

Closed
wants to merge 2 commits into from
Closed

qt5X.full: add missing modules #35070

wants to merge 2 commits into from

Conversation

bjornfor
Copy link
Contributor

@bjornfor bjornfor commented Feb 17, 2018 •
edited

Motivation for this change

Fix regression since qt56.full, where nix-shell -p qt5Full -p qtcreator --run qtcreator was able to build Qt Quick applications.

Things done

Nixpkgs eval is broken on master, so I haven't done all the regular checks.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
qt59.full: add missing modules
adda4f8 
Specifically: qtquickcontrols2, qtwebchannel, qtwebengine, qtwebkit.

This fixes a regression since qt56.full.
@bjornfor
qt510.full: add missing modules
c286b2f 
Specifically: qtquickcontrols2, qtvirtualkeyboard, qtwebchannel,
qtwebengine, qtwebkit.

This fixes a regression since qt56.full.
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

copying path '/nix/store/rwkrcdq3s1lm2zwsmjcgx0fipqjaq2vm-qtwebengine-5.10.0-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/xg3n0p601kp8kfi1k1qjnj2mr40sipmd-qtwebengine-5.10.0-dev' from 'https://cache.nixos.org'...
building '/nix/store/30xz55h8hvwy84yvx5p13ahcc3pbq0fn-qt-5.10.0.drv'...
created 616 symlinks in user environment
copying path '/nix/store/2m5bvk29ilbrq77gmwzxr6vahfscma64-qtwebengine-5.9.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/37kgv4bz3y5rasb7c2f353krkzmbprb4-qtwebengine-5.9.3-dev' from 'https://cache.nixos.org'...
building '/nix/store/hacr164mfz930qqzvk05kr2pi2bniblz-qt-5.9.3.drv'...
created 607 symlinks in user environment
/nix/store/dj78d7y64bzrp27zsb8yzspzrljrm3xl-qt-5.10.0
/nix/store/4qdx63sijs9jpk2kms5baq2dwq3mpmxg-qt-5.9.3

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

*** Downloading ‘https://cache.nixos.org/nar/1di36a6wh7y3w560b23qkhk86frnkiq557z3q3izpwmln4f1q7iq.nar.xz’ (signed by ‘cache.nixos.org-1’) to ‘/nix/store/c3i10sqwvlkcnmsgrg6njdbn9bmchlfg-qtwebkit-5.9.1-dev’...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 30808  100 30808    0     0   113k      0 --:--:-- --:--:-- --:--:--  113k

building path(s) ‘/nix/store/mnh4h0y1qc4rh0zmpkklaxldl7zr49p8-qt-5.9.3’
created 616 symlinks in user environment
created 607 symlinks in user environment
/nix/store/frs2mbldrfm5npl9i66q1x1qzi4h81j1-qt-5.10.0
/nix/store/mnh4h0y1qc4rh0zmpkklaxldl7zr49p8-qt-5.9.3

@bjornfor
Copy link
Contributor Author

Applied to master (7ab1809, 23cdc32).

@bjornfor bjornfor closed this Feb 18, 2018
@bjornfor bjornfor deleted the qt5xfull-add-missing-modules branch February 18, 2018 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bjornfor @GrahamcOfBorg