nixos/znapzend: fix when no previous zetup #35073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the znapzend module was enabled for the first time with pure = true; then the list of previous entries is empty, but xargs still tried to execute a znapzendzetup delete command with no arguments, which made it fail
|
Was confirmed to work by ottidmes and me |
|
Ping @dermetfan @otwieracz @orivej |
|
Sorry, I am no longer able to maintain here - at this moment I have no working NixOS/ZFS setup. |
|
Pinging @7c6f434c @Mic92 @gebner @matthewbauer, this is a trivial change without which the znapzend module doesn't work for new users, would like to have it merged. Should be applied to 18.03 as well. |
|
OK, I cannot test it but it makes a lot of sense. |
7c6f434c
added a commit
that referenced
this pull request
Mar 25, 2018
nixos/znapzend: fix when no previous zetup (cherry picked from commit 296dca0)
|
Picked |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the znapzend module was enabled for the first time with pure =
true; then the list of previous entries is empty, but xargs still tried
to execute a znapzendzetup delete command with no arguments, which made
it fail
Motivation for this change
This was reported by ottidmes on IRC, who was trying to use the module and got an error.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)