zsdcc: init at unstable-2018-02-24 #35463
Conversation
bignaux
changed the title
| @@ -0,0 +1,48 @@ | |||
| { stdenv, sdcc, fetchFromGitHub, ... }: | |||
There was a problem hiding this comment.
Please remove ... and list each needed input explicitly.
There was a problem hiding this comment.
will i not lost the interest of derivate sdcc doing that ?
There was a problem hiding this comment.
I don't understand that question.
|
|
||
| sdcc.overrideAttrs (oldAttrs: rec { | ||
| version = "2018-02-24"; | ||
| name = "zsdcc-unstable-${version}"; # ${oldAttrs.version} |
There was a problem hiding this comment.
I'm not happy about packaging unstable versions. To me, that means it's not ready for Nixpkgs / end users.
There was a problem hiding this comment.
there is no release of zsdcc, and it's not target end users, but users of z88dk that wants to work with new clibs.
| version = "2018-02-24"; | ||
| name = "zsdcc-unstable-${version}"; # ${oldAttrs.version} | ||
|
|
||
| meta = oldAttrs.meta // { |
There was a problem hiding this comment.
The "meta" section is usually at the end of the file.
|
Oh, and please squash the commits. (It looks like only one logical change to me.) |
|
@bignaux are you able to address the comments above? |
|
This PR seems abandoned. @bignaux would you mind closing? |
|
Easy enough to reopen PR if there is interest again. |
Motivation for this change
This provides only zsdcc and zsdcpp for z88dk. Not conflict with sdcc.
@bjornfor : can you have a look please since you are sdcc derivation maintainer ?
Things done
tested with z88dk example.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)