Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
kexectools: Only build on kexecable architectures.
- Loading branch information
Showing
2 changed files
with
6 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ericson2314 FYI. I'd rather a blacklist than a whitelist here, is that doable?
63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's first do #34444 so you can just use
meta.platforms
for this, and then figure out how to add a black list. Pity we don't have a better way to do arbitrary predicates with reflection.63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I feel like parse.nix is the wrong thing to do. We should just define cpuType etc. directly and have a mapping from those to target-triplets.
63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My ideal setup would be two stages of mappings: One from nix
system
string to a{cpu, abi, kernel, etc.}
set, and one from that latter set to target triplets and various system parameters. That way in the ideal case you can just do--argstr cross-system riscv64-linux
but if your case doesn't fit into a nixsystem
you can specify a specific{cpu, abi... }
set.63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Profpatch had similar concerns, but do note it is in fact bidirectional. You can do that already.
63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah actually we can already do the
cross-system
thing with the mapping we already have.63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ericson2314 Yes, but we should just get rid of the one direction 😄 It's hacky and needlessly enshrines a broken model.
63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shlevy okay. I remembered though we still need to be able to parse currentSystem though.
63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I'm fine with parsing the nix system (or, more likely, hard-coding a list). I just don't want to parse triplets.
63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, I didn't mean to frame this as a demand. Just the direction I'd like to see.
63fa1fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nah it's fine. I've been coming around to it. When I first wrote things I preferred config to system because it has more information, but
system
is such better structured (or at least one source of truth with Nix itself). That definitely makes parsing it less fraught.