Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syncthing,qsyncthingtray: remove syncthing-inotify #35432

Merged
merged 1 commit into from Feb 26, 2018
Merged

syncthing,qsyncthingtray: remove syncthing-inotify #35432

merged 1 commit into from Feb 26, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Feb 24, 2018 •
edited

Motivation for this change

syncthing-inotify is deprecated and replaced by the new syncthing "fswatcher" feature.

Fixes #34957

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau
syncthing,qsyncthingtray: remove syncthing-inotify
5643128 
syncthing-inotify is replaced by the new syncthing "fswatcher" feature.
@timokau timokau mentioned this pull request Feb 24, 2018
Closed
@Mic92 Mic92 added this to the 18.03 milestone Feb 24, 2018
@peterhoeg peterhoeg merged commit f9cc3c0 into NixOS:master Feb 26, 2018
@timokau timokau deleted the syncthing-deprecate-inotify branch February 26, 2018 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
18.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @Mic92 @peterhoeg @GrahamcOfBorg