Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/pump.io: remove #35454

Merged
merged 2 commits into from Mar 4, 2018
Merged

nixos/pump.io: remove #35454

merged 2 commits into from Mar 4, 2018

Conversation

rvl
Copy link
Contributor

@rvl rvl commented Feb 24, 2018

It would be nice to merge this before the feature freeze if possible.

Motivation for this change

This would probably be better maintained in a separate repo as an external NixOS module which gets imported into user's configuration.

Upstream is releasing fairly regularly but I doubt we have many/any NixOS users of this (I stopped using it anyway).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

Could you add a a segment in the release notes about this module being dropped?

cc release managers @vcunat @fpletz

@rvl
Copy link
Contributor Author

rvl commented Feb 27, 2018

OK release notes added and rebased onto current master.

@rvl
nixos/pump.io: remove
21dcead 
This would probably be better maintained in a separate repo as an
external NixOS module which gets imported into user's configuration.
@rvl
Release notes: mention removal of pump.io module
c95ef47
vcunat
vcunat approved these changes Mar 4, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also removed the UID.

@vcunat vcunat merged commit c95ef47 into NixOS:master Mar 4, 2018
vcunat added a commit that referenced this pull request Mar 4, 2018
@vcunat
Merge #35454: nixos/pump.io: remove
2069a2a
@rvl
Copy link
Contributor Author

rvl commented Mar 4, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: clean-up 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rvl @adisbladis @vcunat @GrahamcOfBorg