Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notmuch: Fix configure invocation #35442

Merged
merged 1 commit into from Feb 26, 2018
Merged

notmuch: Fix configure invocation #35442

merged 1 commit into from Feb 26, 2018

Conversation

bgamari
Copy link
Contributor

@bgamari bgamari commented Feb 24, 2018

Motivation for this change

Notmuch currently doesn't build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Feb 24, 2018

@GrahamcOfBorg build notmuch

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26/lib/libnotmuch.5.0.0.dylib: fixing dylib
/nix/store/mv5wx6mh18z7q8p47zmkaf5bn5xgahm1-notmuch-0.26

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26
shrinking /nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26/bin/notmuch
shrinking /nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26/lib/libnotmuch.so.5.0.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26/lib  /nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26/bin 
patching script interpreter paths in /nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26
/nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26/bin/notmuch-emacs-mua: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/zqh3l3lyw32q1ayb15bnvg9f24j5v2p0-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-notmuch-0.26.drv-0 in /nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26...
/nix/store/wdw2w2l2armz3q4ri56hanxhgl37d0zp-notmuch-0.26

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

 PASS   reindex detects removal of all files
 PASS   reindex preserves properties

Notmuch test suite complete.
955/960 tests passed.
4 broken tests failed as expected.
1 test failed.
make: *** [test/Makefile.local:71: test] Error 1
builder for '/nix/store/bcai63zwbz18rcvcca56kslrkyq6zcp6-notmuch-0.26.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/bcai63zwbz18rcvcca56kslrkyq6zcp6-notmuch-0.26.drv' failed

@bgamari
Copy link
Contributor Author

bgamari commented Feb 25, 2018

It seems like the notmuch testsuite isn't completely reliable; I saw two failures locally. Nevertheless, this patch is certainly an improvement over the status quo.

@oxij
Copy link
Member

oxij commented Feb 26, 2018 via email

@bgamari
Copy link
Contributor Author

bgamari commented Feb 26, 2018

grep -r parallelBuilding gives no results before this branch. Is that a typo?

Indeed it is; good catch! I do wish that there were a warning for this.

Can you also explain how and why setOutputFlags helps?

I've clarified in the comment.

@Mic92
Copy link
Member

Mic92 commented Feb 26, 2018

cc @andir

@Mic92 Mic92 merged commit 389f2cc into NixOS:master Feb 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bgamari @Mic92 @GrahamcOfBorg @oxij