Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gthumb: fixed mime types #35456

Merged
merged 1 commit into from Feb 24, 2018
Merged

gthumb: fixed mime types #35456

merged 1 commit into from Feb 24, 2018

Conversation

mimame
Copy link
Member

@mimame mimame commented Feb 24, 2018

Fixed #35216
Related to #12280

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji xeji mentioned this pull request Feb 24, 2018
Closed
@Mic92
Copy link
Member

Mic92 commented Feb 24, 2018

@GrahamcOfBorg build gthumb

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘gthumb-3.6.0’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/graphics/gthumb/default.nix:32 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

[ 37%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSSVGForeignObjectElement.cpp.o
[ 37%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSSVGGElement.cpp.o
[ 37%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSSVGGlyphElement.cpp.o
[ 37%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSSVGGlyphRefElement.cpp.o
[ 37%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSSVGGradientElement.cpp.o
[ 37%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSSVGGraphicsElement.cpp.o
[ 37%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSSVGHKernElement.cpp.o
building of '/nix/store/w97rh4yqvkcljgzl705bhhl1v55pq9jd-webkitgtk-2.18.6.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/6dq1q4krix47yrigpibcr76ir7sin8d2-gthumb-3.6.0.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/6dq1q4krix47yrigpibcr76ir7sin8d2-gthumb-3.6.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringConstructor.cpp.o
[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringIteratorPrototype.cpp.o
[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringObject.cpp.o
[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringPrototype.cpp.o
[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StringRecursionChecker.cpp.o
[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/Structure.cpp.o
[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/StructureChain.cpp.o
building of ‘/nix/store/dyl81wpgjsr8wr59pn1nri87kx05waby-webkitgtk-2.18.6.drv’ timed out after 3600 seconds
cannot build derivation ‘/nix/store/x8j4j1zpzqjgjdagnjs423irgrl1g4lz-gthumb-3.6.0.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/x8j4j1zpzqjgjdagnjs423irgrl1g4lz-gthumb-3.6.0.drv’ failed

jtojnar
jtojnar approved these changes Feb 24, 2018
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great.

@jtojnar jtojnar merged commit 114a8f1 into NixOS:master Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mimame @Mic92 @GrahamcOfBorg @jtojnar