Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubernetes: patch broken go version check #35425

Merged
merged 2 commits into from Feb 24, 2018
Merged

kubernetes: patch broken go version check #35425

merged 2 commits into from Feb 24, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Feb 23, 2018

Motivation for this change

fixes #35403
patch from kubernetes/kubernetes#58207
already merged upstream - to be removed for next version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
kubernetes: patch broken go version check
b54e5b9 
fixes NixOS#35403
patch from kubernetes/kubernetes#58207
already merged upstream - remove for next version
@Mic92
Copy link
Member

Mic92 commented Feb 23, 2018

@GrahamcOfBorg build kubernetes

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

!!! [0223 21:57:46]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make: *** [Makefile:92: all] Error 1
make: Leaving directory '/private/tmp/nix-build-kubernetes-1.9.1.drv-0/source'
!!! Error in ./hack/generate-docs.sh:36
  Error in ./hack/generate-docs.sh:36. 'make SHELL=/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash -C "${KUBE_ROOT}" WHAT="${BINS[*]}"' exited with status 2
Call stack:
  1: ./hack/generate-docs.sh:36 main(...)
Exiting with status 1
builder for '/nix/store/zk392696lyw2ml5456nanm5w099a14cp-kubernetes-1.9.1.drv' failed with exit code 1
error: build of '/nix/store/zk392696lyw2ml5456nanm5w099a14cp-kubernetes-1.9.1.drv' failed

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/msga040q36p8qqaz4w7zgv1smbh45jp1-kubernetes-1.9.1-man
checking for references to /build in /nix/store/msga040q36p8qqaz4w7zgv1smbh45jp1-kubernetes-1.9.1-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/hjdb5dcvhm4ryb1nsrdhva60cn84ib43-kubernetes-1.9.1-pause
shrinking /nix/store/hjdb5dcvhm4ryb1nsrdhva60cn84ib43-kubernetes-1.9.1-pause/bin/pause
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hjdb5dcvhm4ryb1nsrdhva60cn84ib43-kubernetes-1.9.1-pause/bin
patching script interpreter paths in /nix/store/hjdb5dcvhm4ryb1nsrdhva60cn84ib43-kubernetes-1.9.1-pause
checking for references to /build in /nix/store/hjdb5dcvhm4ryb1nsrdhva60cn84ib43-kubernetes-1.9.1-pause...
/nix/store/layffb1y61f2k2nl8sh38v6vb69zaf9p-kubernetes-1.9.1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/x6v27bk6apj7piil6jrrn8pf81gd5irs-kubernetes-1.9.1-man
checking for references to /tmp/nix-build-kubernetes-1.9.1.drv-0 in /nix/store/x6v27bk6apj7piil6jrrn8pf81gd5irs-kubernetes-1.9.1-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/bvrm0pymqyy4s5n4rdj3azmpjyn6wimz-kubernetes-1.9.1-pause
shrinking /nix/store/bvrm0pymqyy4s5n4rdj3azmpjyn6wimz-kubernetes-1.9.1-pause/bin/pause
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bvrm0pymqyy4s5n4rdj3azmpjyn6wimz-kubernetes-1.9.1-pause/bin 
patching script interpreter paths in /nix/store/bvrm0pymqyy4s5n4rdj3azmpjyn6wimz-kubernetes-1.9.1-pause
checking for references to /tmp/nix-build-kubernetes-1.9.1.drv-0 in /nix/store/bvrm0pymqyy4s5n4rdj3azmpjyn6wimz-kubernetes-1.9.1-pause...
/nix/store/p5ycisrni3c0vwp0jaj0dwnn5c3jjg52-kubernetes-1.9.1

@xeji
Copy link
Contributor Author

xeji commented Feb 24, 2018 •
edited

No idea what causes failure on darwin but looks unrelated to my patch. Unable to investigate.

@Mic92
Copy link
Member

Mic92 commented Feb 24, 2018

@GrahamcOfBorg build kubernetes

@Mic92
Copy link
Member

Mic92 commented Feb 24, 2018

@GrahamcOfBorg test kubernetes

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m while evaluating 'hydraJob' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:168:14, called from �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/nixos/release.nix�[0m:292:22:
while evaluating the attribute 'name' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:173:24:
attribute 'name' missing, at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:173:10

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

!!! [0224 00:37:23]  1: hack/make-rules/build.sh:27 kube::golang::build_binaries(...)
make: *** [Makefile:92: all] Error 1
make: Leaving directory '/private/tmp/nix-build-kubernetes-1.9.1.drv-0/source'
!!! Error in ./hack/generate-docs.sh:36
  Error in ./hack/generate-docs.sh:36. 'make SHELL=/nix/store/pkjmwq7sqrvjg7cjiph6hq0khsmfl6p8-bash-4.4-p12/bin/bash -C "${KUBE_ROOT}" WHAT="${BINS[*]}"' exited with status 2
Call stack:
  1: ./hack/generate-docs.sh:36 main(...)
Exiting with status 1
builder for '/nix/store/kvn0wzs4qjcdyj591gd7k9yr9gldzpmi-kubernetes-1.9.1.drv' failed with exit code 1
error: build of '/nix/store/kvn0wzs4qjcdyj591gd7k9yr9gldzpmi-kubernetes-1.9.1.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/kfsamz5vbpayyjgq1g85jvw9h8ymdxk8-kubernetes-1.9.1-man
checking for references to /tmp/nix-build-kubernetes-1.9.1.drv-0 in /nix/store/kfsamz5vbpayyjgq1g85jvw9h8ymdxk8-kubernetes-1.9.1-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/x5w1s63l5z9x9jlymr8hycrq6x7gfl8f-kubernetes-1.9.1-pause
shrinking /nix/store/x5w1s63l5z9x9jlymr8hycrq6x7gfl8f-kubernetes-1.9.1-pause/bin/pause
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/x5w1s63l5z9x9jlymr8hycrq6x7gfl8f-kubernetes-1.9.1-pause/bin 
patching script interpreter paths in /nix/store/x5w1s63l5z9x9jlymr8hycrq6x7gfl8f-kubernetes-1.9.1-pause
checking for references to /tmp/nix-build-kubernetes-1.9.1.drv-0 in /nix/store/x5w1s63l5z9x9jlymr8hycrq6x7gfl8f-kubernetes-1.9.1-pause...
/nix/store/3brjqv4kfa02bhlpzijn5ahf48yigkjn-kubernetes-1.9.1

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: while evaluating ‘hydraJob’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:168:14, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/nixos/release.nix:292:22:
while evaluating the attribute ‘system’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:173:24:
attribute ‘system’ missing, at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:173:10

@Mic92 Mic92 merged commit e9fdcc9 into NixOS:master Feb 24, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/pjlsynjd21wjblr8dc1vy788qvfp612n-kubernetes-1.9.1-man
checking for references to /build in /nix/store/pjlsynjd21wjblr8dc1vy788qvfp612n-kubernetes-1.9.1-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/yhmlckhzkr8jwdhmmj2valkp5w4izlp3-kubernetes-1.9.1-pause
shrinking /nix/store/yhmlckhzkr8jwdhmmj2valkp5w4izlp3-kubernetes-1.9.1-pause/bin/pause
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yhmlckhzkr8jwdhmmj2valkp5w4izlp3-kubernetes-1.9.1-pause/bin
patching script interpreter paths in /nix/store/yhmlckhzkr8jwdhmmj2valkp5w4izlp3-kubernetes-1.9.1-pause
checking for references to /build in /nix/store/yhmlckhzkr8jwdhmmj2valkp5w4izlp3-kubernetes-1.9.1-pause...
/nix/store/cfqll0g3gsyrwc12hjj9cxry4v8qdb3m-kubernetes-1.9.1

@xeji xeji deleted the kubernetes-go-version branch February 24, 2018 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubernetes broken
3 participants
@xeji @Mic92 @GrahamcOfBorg