pythonPackages.py_stringmatching: init at 0.4.0 #35471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
requested changes
Feb 24, 2018
| sha256 = "0rjsx7iipn6svki21lmsza7b0dz9vkgmix696zryiv7gkhblqyb4"; | ||
| }; | ||
|
|
||
| # No tests in archive |
There was a problem hiding this comment.
Wrong! Just look in py_stringmatching/tests/.
Please enable tests and use nosetests in the checkPhase.
| propagatedBuildInputs = [ numpy six ]; | ||
|
|
||
| meta = with lib; { | ||
| description = "This project seeks to build a Python software package that consists of a comprehensive and scalable set of string tokenizers (such as alphabetical tokenizers, whitespace tokenizers) and string similarity measures (such as edit distance, Jaccard, TF/IDF)."; |
There was a problem hiding this comment.
Too long. This could be a longDescription. Also please split it into multiple lines.
| @@ -0,0 +1,29 @@ | |||
|
|
|||
|
@dotlambda should be alright now! |
|
@GrahamcOfBorg build python2.pkgs.py_stringmatching python3.pkgs.py_stringmatching |
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
dotlambda
requested changes
Feb 25, 2018
| propagatedBuildInputs = [ numpy six ]; | ||
|
|
||
| meta = with lib; { | ||
| description = "A Python string matching library including string tokenizers and string similarity measures."; |
There was a problem hiding this comment.
No period. See https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes.
There was a problem hiding this comment.
Also, you can keep the previous description as longDescription if you want.
|
@dotlambda - I applied the requested changes. |
dotlambda
approved these changes
Feb 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)