pythonPackages.jupyterhub-ldapauthenticator: init at 1.1 #35467

ixxie · 2018-02-24T12:18:07Z

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-02-24T16:09:09Z

pkgs/development/python-modules/jupyterhub-ldapauthenticator/default.nix

+
+  propagatedBuildInputs = [ jupyterhub ldap3 ];
+
+  disabled = pythonOlder "3.4";


Why that? The README says

I've only tested with python3 - anyone willing to test with python2 is welcome to do so! There's no reason it shouldn't work.

dotlambda · 2018-02-24T16:09:40Z

pkgs/development/python-modules/jupyterhub-ldapauthenticator/default.nix

+    sha256 = "19dz3a3122wln8lkixj5jbh9x3cqlrcb3p7a53825cj72cmpcxwz";
+  };
+
+  # No tests in archive


There aren't even any on GitHub, so this should say something like No tests implemented

dotlambda · 2018-02-24T16:09:50Z

pkgs/development/python-modules/jupyterhub-ldapauthenticator/default.nix

@@ -0,0 +1,32 @@
+


ixxie · 2018-02-24T20:39:57Z

@dotlambda - whoopsy, been a little sloppy there! Fixed now, hopefully.

dotlambda · 2018-02-25T09:21:42Z

@GrahamcOfBorg build python2.pkgs.jupyterhub-ldapauthenticator python3.pkgs.jupyterhub-ldapauthenticator

GrahamcOfBorg · 2018-02-25T09:21:50Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

while evaluating ‘getOutput’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/attrsets.nix:450:23, called from undefined position:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/stdenv/generic/make-derivation.nix:111:17, called from undefined position:
while evaluating ‘callPackageWith’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:113:35, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/top-level/python-packages.nix:9304:16:
while evaluating ‘makeOverridable’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:72:24, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:117:8:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/development/python-modules/jupyterhub/default.nix:1:1, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:74:12:
while evaluating ‘makeOverridablePythonPackage’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/top-level/python-packages.nix:40:37, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/development/python-modules/jupyterhub/default.nix:51:1:
while evaluating ‘makeOverridable’ at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:72:24, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/top-level/python-packages.nix:42:12:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/development/interpreters/python/build-python-package.nix:26:1, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/lib/customisation.nix:74:12:
while evaluating anonymous function at /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/development/interpreters/python/mk-python-derivation.nix:14:1, called from /var/lib/gc-of-borg/.nix-test-rs/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/ogden/pkgs/development/interpreters/python/build-python-package.nix:43:4:
jupyterhub-0.8.1 not supported for interpreter python2.7

GrahamcOfBorg · 2018-02-25T09:22:00Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

while evaluating 'getOutput' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/attrsets.nix�[0m:450:23, called from undefined position:
while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/stdenv/generic/make-derivation.nix�[0m:111:17, called from undefined position:
while evaluating 'callPackageWith' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:113:35, called from �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/top-level/python-packages.nix�[0m:9304:16:
while evaluating 'makeOverridable' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:72:24, called from �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:117:8:
while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/python-modules/jupyterhub/default.nix�[0m:1:1, called from �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:74:12:
while evaluating 'makeOverridablePythonPackage' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/top-level/python-packages.nix�[0m:40:37, called from �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/python-modules/jupyterhub/default.nix�[0m:51:1:
while evaluating 'makeOverridable' at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:72:24, called from �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/top-level/python-packages.nix�[0m:42:12:
while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/interpreters/python/build-python-package.nix�[0m:26:1, called from �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/lib/customisation.nix�[0m:74:12:
while evaluating anonymous function at �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/interpreters/python/mk-python-derivation.nix�[0m:14:1, called from �[1m/var/lib/gc-of-borg/nix-test-rs-1/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-1/pkgs/development/interpreters/python/build-python-package.nix�[0m:43:4:
jupyterhub-0.8.1 not supported for interpreter python2.7

dotlambda · 2018-02-25T09:23:16Z

@GrahamcOfBorg build python3.pkgs.jupyterhub-ldapauthenticator

@ixxie You might want to add disabled = !isPy3k.

GrahamcOfBorg · 2018-02-25T09:23:23Z

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘python3’ in selection path ‘python3.pkgs.python3.pkgs.jupyterhub-ldapauthenticator’ not found

GrahamcOfBorg · 2018-02-25T09:23:31Z

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m attribute 'python3' in selection path 'python3.pkgs.python3.pkgs.jupyterhub-ldapauthenticator' not found

GrahamcOfBorg · 2018-02-25T09:23:59Z

Success on x86_64-linux (full log)

Partial log (click to expand)

Installing collected packages: jupyterhub-ldapauthenticator
Successfully installed jupyterhub-ldapauthenticator-1.1
/tmp/nix-build-python3.6-jupyterhub-ldapauthenticator-1.1.drv-0/jupyterhub-ldapauthenticator-1.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/s708qhd4ryxiz0azlsjpab52yk43z3n2-python3.6-jupyterhub-ldapauthenticator-1.1
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/s708qhd4ryxiz0azlsjpab52yk43z3n2-python3.6-jupyterhub-ldapauthenticator-1.1/lib 
patching script interpreter paths in /nix/store/s708qhd4ryxiz0azlsjpab52yk43z3n2-python3.6-jupyterhub-ldapauthenticator-1.1
checking for references to /tmp/nix-build-python3.6-jupyterhub-ldapauthenticator-1.1.drv-0 in /nix/store/s708qhd4ryxiz0azlsjpab52yk43z3n2-python3.6-jupyterhub-ldapauthenticator-1.1...
/nix/store/s708qhd4ryxiz0azlsjpab52yk43z3n2-python3.6-jupyterhub-ldapauthenticator-1.1

dotlambda · 2018-02-25T09:27:18Z

pkgs/development/python-modules/jupyterhub-ldapauthenticator/default.nix

+  propagatedBuildInputs = [ jupyterhub ldap3 ];
+
+  meta = with lib; {
+    description = "Simple LDAP Authenticator Plugin for JupyterHub.";


dotlambda · 2018-02-25T09:27:48Z

pkgs/development/python-modules/jupyterhub-ldapauthenticator/default.nix

+, buildPythonPackage
+, jupyterhub
+, ldap3
+, pythonOlder


GrahamcOfBorg · 2018-02-25T09:30:40Z

Success on aarch64-linux (full log)

Partial log (click to expand)

Installing collected packages: jupyterhub-ldapauthenticator
Successfully installed jupyterhub-ldapauthenticator-1.1
/build/jupyterhub-ldapauthenticator-1.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/a95dawf4zpxfmy9qcdlf084fsrgznpw7-python3.6-jupyterhub-ldapauthenticator-1.1
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/a95dawf4zpxfmy9qcdlf084fsrgznpw7-python3.6-jupyterhub-ldapauthenticator-1.1/lib
patching script interpreter paths in /nix/store/a95dawf4zpxfmy9qcdlf084fsrgznpw7-python3.6-jupyterhub-ldapauthenticator-1.1
checking for references to /build in /nix/store/a95dawf4zpxfmy9qcdlf084fsrgznpw7-python3.6-jupyterhub-ldapauthenticator-1.1...
/nix/store/a95dawf4zpxfmy9qcdlf084fsrgznpw7-python3.6-jupyterhub-ldapauthenticator-1.1

ixxie · 2018-02-25T18:11:33Z

@dotlambda - I applied the requested changes. I didn't use the disabled = !isPy3k because the github page for the package says this could in principle work on python2 but simply wasn't tested.

ixxie requested a review from FRidh as a code owner February 24, 2018 12:18

ixxie changed the title ~~pythonPackages.jupyterhub-oauthenticator: init at 1.1~~ pythonPackages.jupyterhub-ldapauthenticator: init at 1.1 Feb 24, 2018

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 24, 2018

dotlambda requested changes Feb 24, 2018

View reviewed changes

dotlambda requested changes Feb 25, 2018

View reviewed changes

pythonPackages.jupyterhub-ldapauthenticator: init at 1.1

23b6f5e

dotlambda approved these changes Feb 25, 2018

View reviewed changes

FRidh merged commit e6cc9a7 into NixOS:master Feb 26, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.jupyterhub-ldapauthenticator: init at 1.1 #35467

pythonPackages.jupyterhub-ldapauthenticator: init at 1.1 #35467

ixxie commented Feb 24, 2018

dotlambda Feb 24, 2018

dotlambda Feb 24, 2018

dotlambda Feb 24, 2018

ixxie commented Feb 24, 2018

dotlambda commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

dotlambda commented Feb 25, 2018 •

edited

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

dotlambda Feb 25, 2018

dotlambda Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

ixxie commented Feb 25, 2018


		propagatedBuildInputs = [ jupyterhub ldap3 ];

		disabled = pythonOlder "3.4";

pythonPackages.jupyterhub-ldapauthenticator: init at 1.1 #35467

pythonPackages.jupyterhub-ldapauthenticator: init at 1.1 #35467

Conversation

ixxie commented Feb 24, 2018

dotlambda Feb 24, 2018

Choose a reason for hiding this comment

dotlambda Feb 24, 2018

Choose a reason for hiding this comment

dotlambda Feb 24, 2018

Choose a reason for hiding this comment

ixxie commented Feb 24, 2018

dotlambda commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

dotlambda commented Feb 25, 2018 • edited

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

GrahamcOfBorg commented Feb 25, 2018

dotlambda Feb 25, 2018

Choose a reason for hiding this comment

dotlambda Feb 25, 2018

Choose a reason for hiding this comment

GrahamcOfBorg commented Feb 25, 2018

ixxie commented Feb 25, 2018

dotlambda commented Feb 25, 2018 •

edited