Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bwm-ng: fix build error with gcc7 #35431

Merged
merged 1 commit into from Feb 24, 2018
Merged

bwm-ng: fix build error with gcc7 #35431

merged 1 commit into from Feb 24, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Feb 23, 2018

Motivation for this change

bwm_ng failed to build after switch to gcc7.
caused by some gcc7 issues with inline functions.

Things done
  • [x ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
bwm-ng: fix build error with gcc7
2ad6f04 
patch some gcc7 issues with inline functions
@Mic92
Copy link
Member

Mic92 commented Feb 24, 2018

@GrahamcOfBorg build bwm-ng

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m attribute 'bwm-ng' in selection path 'bwm-ng' not found

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: attribute 'bwm-ng' in selection path 'bwm-ng' not found

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute ‘bwm-ng’ in selection path ‘bwm-ng’ not found

@Mic92
Copy link
Member

Mic92 commented Feb 24, 2018

@GrahamcOfBorg build bwm_ng

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/tmp/nix-build-bwm-ng-0.6.1.drv-0/bwm-ng-0.6.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/mp9yy8288h70bsv10h4jy6px9sc78730-bwm-ng-0.6.1
shrinking /nix/store/mp9yy8288h70bsv10h4jy6px9sc78730-bwm-ng-0.6.1/bin/bwm-ng
gzipping man pages under /nix/store/mp9yy8288h70bsv10h4jy6px9sc78730-bwm-ng-0.6.1/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/mp9yy8288h70bsv10h4jy6px9sc78730-bwm-ng-0.6.1/bin 
patching script interpreter paths in /nix/store/mp9yy8288h70bsv10h4jy6px9sc78730-bwm-ng-0.6.1
checking for references to /tmp/nix-build-bwm-ng-0.6.1.drv-0 in /nix/store/mp9yy8288h70bsv10h4jy6px9sc78730-bwm-ng-0.6.1...
/nix/store/mp9yy8288h70bsv10h4jy6px9sc78730-bwm-ng-0.6.1

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

 /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/mkdir -p '/nix/store/zk49clygx81ql322j3chhdd25691zr0w-bwm-ng-0.6.1/share/man/man1'
 /nix/store/6b3jzg40vibmrjg85i46vvidyy915428-coreutils-8.29/bin/install -c -m 644 bwm-ng.1 '/nix/store/zk49clygx81ql322j3chhdd25691zr0w-bwm-ng-0.6.1/share/man/man1'
make[2]: Leaving directory '/private/tmp/nix-build-bwm-ng-0.6.1.drv-0/bwm-ng-0.6.1'
make[1]: Leaving directory '/private/tmp/nix-build-bwm-ng-0.6.1.drv-0/bwm-ng-0.6.1'
post-installation fixup
gzipping man pages under /nix/store/zk49clygx81ql322j3chhdd25691zr0w-bwm-ng-0.6.1/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/zk49clygx81ql322j3chhdd25691zr0w-bwm-ng-0.6.1/bin
patching script interpreter paths in /nix/store/zk49clygx81ql322j3chhdd25691zr0w-bwm-ng-0.6.1
/nix/store/zk49clygx81ql322j3chhdd25691zr0w-bwm-ng-0.6.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

make[1]: Leaving directory '/build/bwm-ng-0.6.1'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/lr72cdrvhjbchdp4jxhg980vfws9z9sg-bwm-ng-0.6.1
shrinking /nix/store/lr72cdrvhjbchdp4jxhg980vfws9z9sg-bwm-ng-0.6.1/bin/bwm-ng
gzipping man pages under /nix/store/lr72cdrvhjbchdp4jxhg980vfws9z9sg-bwm-ng-0.6.1/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/lr72cdrvhjbchdp4jxhg980vfws9z9sg-bwm-ng-0.6.1/bin
patching script interpreter paths in /nix/store/lr72cdrvhjbchdp4jxhg980vfws9z9sg-bwm-ng-0.6.1
checking for references to /build in /nix/store/lr72cdrvhjbchdp4jxhg980vfws9z9sg-bwm-ng-0.6.1...
/nix/store/lr72cdrvhjbchdp4jxhg980vfws9z9sg-bwm-ng-0.6.1

@Mic92 Mic92 merged commit cd55094 into NixOS:master Feb 24, 2018
@xeji xeji deleted the bwm-ng branch February 24, 2018 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @Mic92 @GrahamcOfBorg