geeqie: 1.3 -> 1.4 #35462
geeqie: 1.3 -> 1.4 #35462
Conversation
| @@ -45,7 +48,7 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| homepage = http://geeqie.sourceforge.net; | |||
There was a problem hiding this comment.
Could you change this to http://geeqie.org?
There was a problem hiding this comment.
Will do that in 1.4.1. Thank you for your review!
| }; | ||
|
|
||
| preConfigure = "./autogen.sh"; | ||
| # Do not build the changelog as this requires markdown. |
There was a problem hiding this comment.
It looks like it i more of because a missing file: BestImageViewer/geeqie#568 If markdown is missing, README.html generation is just skipped.
There was a problem hiding this comment.
You are right. My comment there is wrong. I will remove it when 1.4.1 is released.
|
|
||
| configureFlags = [ "--enable-gps" ]; | ||
| preConfigure = "./autogen.sh"; |
There was a problem hiding this comment.
I think you are supposed to add NOCONFIGURE=1 before ./autogen.sh. That way configuration will actually be done during configurePhase.
There was a problem hiding this comment.
Looks like it. The --enable-gps flag however was renamed and enabled by default anyway which is why I removed it. It would be probably best to still add NOCONFIGURE in case someone would want to enable or disable a feature in the future.
There was a problem hiding this comment.
NOCONFIGURE just prevents, running ./configure from ./autogen.sh, which is not needed since it will be called in configurePhase.
|
Hmm, I am two hours late with my review 🕴️ |
Motivation for this change
Update and build with default features.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)cc @pSub