Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 8e28ddcc281a
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 6471bc073d48
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Feb 24, 2018

  1. Kill a few more Data lookups.

    headius committed Feb 24, 2018

    Verified

    This commit was signed with the committer’s verified signature.
    headius Charles Oliver Nutter
    Copy the full SHA
    b90caf1 View commit details
  2. Fix references to Fixnum.

    headius committed Feb 24, 2018
    Copy the full SHA
    6471bc0 View commit details
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/RubyConverter.java
Original file line number Diff line number Diff line change
@@ -114,7 +114,7 @@ public class RubyConverter extends RubyObject {
}

public static RubyClass createConverterClass(Ruby runtime) {
RubyClass converterc = runtime.defineClassUnder("Converter", runtime.getClass("Data"), CONVERTER_ALLOCATOR, runtime.getEncoding());
RubyClass converterc = runtime.defineClassUnder("Converter", runtime.getData(), CONVERTER_ALLOCATOR, runtime.getEncoding());
runtime.setConverter(converterc);
converterc.setClassIndex(ClassIndex.CONVERTER);
converterc.setReifiedClass(RubyConverter.class);
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/RubyNameError.java
Original file line number Diff line number Diff line change
@@ -161,7 +161,7 @@ static RubyClass createNameErrorClass(Ruby runtime, RubyClass StandardError) {
}

static RubyClass createNameErrorMessageClass(Ruby runtime, RubyClass NameError) {
RubyClass Message = NameError.defineClassUnder("Message", runtime.getClass("Data"), RubyNameErrorMessage.ALLOCATOR);
RubyClass Message = NameError.defineClassUnder("Message", runtime.getData(), RubyNameErrorMessage.ALLOCATOR);
NameError.setConstantVisibility(runtime, "Message", true);
Message.defineAnnotatedMethods(RubyNameErrorMessage.class);
return Message;
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/ext/socket/Addrinfo.java
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@ public class Addrinfo extends RubyObject {
public static void createAddrinfo(Ruby runtime) {
RubyClass addrinfo = runtime.defineClass(
"Addrinfo",
runtime.getClass("Data"),
runtime.getData(),
new ObjectAllocator() {
public IRubyObject allocate(Ruby runtime, RubyClass klazz) {
return new Addrinfo(runtime, klazz);
2 changes: 1 addition & 1 deletion core/src/main/java/org/jruby/ext/socket/Ifaddr.java
Original file line number Diff line number Diff line change
@@ -39,7 +39,7 @@ public class Ifaddr extends RubyObject {
public static void createIfaddr(Ruby runtime) {
RubyClass ifaddr = runtime.getClass("Socket").defineClassUnder(
"Ifaddr",
runtime.getClass("Data"),
runtime.getData(),
new ObjectAllocator() {
public IRubyObject allocate(Ruby runtime, RubyClass klazz) {
return new Ifaddr(runtime, klazz);
2 changes: 1 addition & 1 deletion lib/ruby/stdlib/date.rb
Original file line number Diff line number Diff line change
@@ -825,7 +825,7 @@ def self.ordinal(y=-4712, d=1, sg=ITALY)
#
# +sg+ specifies the Day of Calendar Reform.
def self.civil(y=-4712, m=1, d=1, sg=ITALY)
if Fixnum === y and Fixnum === m and Fixnum === d and d > 0
if Integer === y and Integer === m and Integer === d and d > 0
m += 13 if m < 0
y -= 1 if y <= 0 and sg > 0 # TODO
begin