Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.TextBibTeX: fix dylib path for Darwin #35438

Merged
merged 2 commits into from Mar 4, 2018
Merged

perlPackages.TextBibTeX: fix dylib path for Darwin #35438

merged 2 commits into from Mar 4, 2018

Conversation

boronine
Copy link
Contributor

Motivation for this change

The package pkgs.perlPackages.TextBibTeX didn't work on Darwin due to the (common) dylib location issue.

Things done

This package comes with a 1 dylib and 3 executables. I used install_name_tool to patch the binaries to switch the dylib location from the build directory (wrong) to the final Nix store directory (right).

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@boronine boronine mentioned this pull request Feb 24, 2018
Closed
@boronine boronine changed the title perlPackages.TextBibTex: fix dylib path for Darwin perlPackages.TextBibTeX: fix dylib path for Darwin Feb 24, 2018
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Feb 24, 2018
@boronine
Copy link
Contributor Author

Forgot to patch .bundle file in original commit. Fixed and re-tested.

@boronine
Copy link
Contributor Author

@vcunat

@vcunat
Copy link
Member

vcunat commented Feb 24, 2018

I'm no good with Darwin stuff.

@vcunat
Copy link
Member

vcunat commented Feb 24, 2018

@GrahamcOfBorg perlPackages.TextBibTeX

@vcunat
Copy link
Member

vcunat commented Feb 24, 2018

@GrahamcOfBorg build perlPackages.TextBibTeX

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/fa4f8q3yvir35lymcqn6kah4dqcy8vn7-perl-Text-BibTeX-0.81/lib  /nix/store/fa4f8q3yvir35lymcqn6kah4dqcy8vn7-perl-Text-BibTeX-0.81/lib64  /nix/store/fa4f8q3yvir35lymcqn6kah4dqcy8vn7-perl-Text-BibTeX-0.81/bin 
patching script interpreter paths in /nix/store/fa4f8q3yvir35lymcqn6kah4dqcy8vn7-perl-Text-BibTeX-0.81
checking for references to /tmp/nix-build-perl-Text-BibTeX-0.81.drv-0 in /nix/store/fa4f8q3yvir35lymcqn6kah4dqcy8vn7-perl-Text-BibTeX-0.81...
moving /nix/store/fa4f8q3yvir35lymcqn6kah4dqcy8vn7-perl-Text-BibTeX-0.81/lib64/* to /nix/store/fa4f8q3yvir35lymcqn6kah4dqcy8vn7-perl-Text-BibTeX-0.81/lib
shrinking RPATHs of ELF executables and libraries in /nix/store/man0pdbf23ipw3gqa5bgnppfl5mhpzs1-perl-Text-BibTeX-0.81-devdoc
gzipping man pages under /nix/store/man0pdbf23ipw3gqa5bgnppfl5mhpzs1-perl-Text-BibTeX-0.81-devdoc/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/man0pdbf23ipw3gqa5bgnppfl5mhpzs1-perl-Text-BibTeX-0.81-devdoc
checking for references to /tmp/nix-build-perl-Text-BibTeX-0.81.drv-0 in /nix/store/man0pdbf23ipw3gqa5bgnppfl5mhpzs1-perl-Text-BibTeX-0.81-devdoc...
/nix/store/fa4f8q3yvir35lymcqn6kah4dqcy8vn7-perl-Text-BibTeX-0.81

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/faaadks90ysgsrap8ys33np568ly1fq5-perl-Text-BibTeX-0.81/lib  /nix/store/faaadks90ysgsrap8ys33np568ly1fq5-perl-Text-BibTeX-0.81/lib64  /nix/store/faaadks90ysgsrap8ys33np568ly1fq5-perl-Text-BibTeX-0.81/bin
patching script interpreter paths in /nix/store/faaadks90ysgsrap8ys33np568ly1fq5-perl-Text-BibTeX-0.81
checking for references to /build in /nix/store/faaadks90ysgsrap8ys33np568ly1fq5-perl-Text-BibTeX-0.81...
moving /nix/store/faaadks90ysgsrap8ys33np568ly1fq5-perl-Text-BibTeX-0.81/lib64/* to /nix/store/faaadks90ysgsrap8ys33np568ly1fq5-perl-Text-BibTeX-0.81/lib
shrinking RPATHs of ELF executables and libraries in /nix/store/30zyc7z011y3cgwqrydpfpqrqzvz6vmg-perl-Text-BibTeX-0.81-devdoc
gzipping man pages under /nix/store/30zyc7z011y3cgwqrydpfpqrqzvz6vmg-perl-Text-BibTeX-0.81-devdoc/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/30zyc7z011y3cgwqrydpfpqrqzvz6vmg-perl-Text-BibTeX-0.81-devdoc
checking for references to /build in /nix/store/30zyc7z011y3cgwqrydpfpqrqzvz6vmg-perl-Text-BibTeX-0.81-devdoc...
/nix/store/faaadks90ysgsrap8ys33np568ly1fq5-perl-Text-BibTeX-0.81

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

Moving /nix/store/67ik3454xnvlgmx7fqn4kdzjyphbj6bg-perl-Text-BibTeX-0.81/share/man/man3 to /nix/store/hz78l19mh7s7a5kgcpvc2xxinn9j0xgd-perl-Text-BibTeX-0.81-devdoc/share/man/man3
rmdir: failed to remove '/nix/store/67ik3454xnvlgmx7fqn4kdzjyphbj6bg-perl-Text-BibTeX-0.81/share/man': Directory not empty
gzipping man pages under /nix/store/67ik3454xnvlgmx7fqn4kdzjyphbj6bg-perl-Text-BibTeX-0.81/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/67ik3454xnvlgmx7fqn4kdzjyphbj6bg-perl-Text-BibTeX-0.81/lib  /nix/store/67ik3454xnvlgmx7fqn4kdzjyphbj6bg-perl-Text-BibTeX-0.81/bin
patching script interpreter paths in /nix/store/67ik3454xnvlgmx7fqn4kdzjyphbj6bg-perl-Text-BibTeX-0.81
gzipping man pages under /nix/store/hz78l19mh7s7a5kgcpvc2xxinn9j0xgd-perl-Text-BibTeX-0.81-devdoc/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/hz78l19mh7s7a5kgcpvc2xxinn9j0xgd-perl-Text-BibTeX-0.81-devdoc
/nix/store/67ik3454xnvlgmx7fqn4kdzjyphbj6bg-perl-Text-BibTeX-0.81

@Mic92 Mic92 merged commit 0be67e2 into NixOS:master Mar 4, 2018
@boronine boronine deleted the bibtex-darwin-fix branch March 5, 2018 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@boronine @vcunat @GrahamcOfBorg @Mic92