sequeler: init at 0.5.3 #35472
sequeler: init at 0.5.3 #35472
Conversation
GrahamcOfBorg
added
the
6.topic: GNOME
|
This was my attempt at packaging it few days ago: --- /dev/null
+++ b/pkgs/applications/misc/sequeler/default.nix
@@ -0,0 +1,55 @@
+{ stdenv
+, fetchFromGitHub
+, cmake
+, ninja
+, pkgconfig
+, vala
+, gettext
+, libxml2
+, gobjectIntrospection
+, wrapGAppsHook
+, gtk3
+, glib
+, granite
+, gnome3
+}:
+
+stdenv.mkDerivation rec {
+ name = "sequeler-${version}";
+ version = "0.5.1";
+
+ src = fetchFromGitHub {
+ owner = "Alecaddd";
+ repo = "sequeler";
+ rev = "v${version}";
+ sha256 = "1gphmd56kib757rwblsx9m2a4qqbm6pm9bjj8mh5xcc9jhws9vrj";
+ };
+
+ nativeBuildInputs = [
+ cmake
+ ninja
+ pkgconfig
+ vala
+ gobjectIntrospection
+ gettext
+ wrapGAppsHook
+ ];
+
+ buildInputs = [
+ gtk3
+ glib
+ granite
+ gnome3.libgee
+ libxml2 # required by libgda
+ gnome3.libgda
+ gnome3.gtksourceview
+ ];
+
+ meta = with stdenv.lib; {
+ description = "Friendly SQL Client";
+ homepage = https://github.com/Alecaddd/sequeler;
+ maintainers = with maintainers; [ jtojnar ];
+ license = licenses.gpl3;
+ platforms = platforms.linux;
+ };
+}
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -4606,6 +4606,8 @@
seqdiag = pythonPackages.seqdiag;
+ sequeler = callPackage ../applications/misc/sequeler { };
+
screenfetch = callPackage ../tools/misc/screenfetch { };
sg3_utils = callPackage ../tools/system/sg3_utils { }; |
| @@ -11,16 +17,23 @@ stdenv.mkDerivation rec { | |||
| }) | |||
| ]; | |||
|
|
|||
| configureFlags = [ | |||
| "--enable-gi-system-install=no" | |||
| NIX_CFLAGS_COMPILE = stdenv.lib.optionals mysqlSupport [ | |||
There was a problem hiding this comment.
In my packaging, MySQL works for me even without NIX_CFLAGS_COMPILE. My lazy attempt without conditionals:
--- a/pkgs/desktops/gnome-3/misc/libgda/default.nix
+++ b/pkgs/desktops/gnome-3/misc/libgda/default.nix
@@ -1,4 +1,4 @@
-{ stdenv, fetchurl, fetchpatch, pkgconfig, intltool, itstool, libxml2, gtk3, openssl }:
+{ stdenv, fetchurl, fetchpatch, pkgconfig, intltool, itstool, libxml2, gtk3, openssl, postgresql, mysql }:
stdenv.mkDerivation rec {
inherit (import ./src.nix fetchurl) name src;
@@ -20,7 +20,7 @@
hardeningDisable = [ "format" ];
nativeBuildInputs = [ pkgconfig ];
- buildInputs = [ intltool itstool libxml2 gtk3 openssl ];
+ buildInputs = [ intltool itstool libxml2 gtk3 openssl postgresql mysql.connector-c ];
meta = with stdenv.lib; {
description = "Database access library";There was a problem hiding this comment.
Nice, removed the cflags but it remained as optionals 👍
| enableParallelBuilding = true; | ||
|
|
||
| hardeningDisable = [ "format" ]; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig ]; | ||
| buildInputs = [ intltool itstool libxml2 gtk3 openssl ]; | ||
| buildInputs = with stdenv.lib; [ intltool itstool libxml2 gtk3 openssl ] |
There was a problem hiding this comment.
Actually, since you are touching this, could you move intltool itstool libxml2 to nativeBuildInputs?
| sha256 = "0m5zwl9jfdl1dzd1ymlwx7rx5cr9fdx06sbnidaajh33z02zaph0"; | ||
| }; | ||
|
|
||
| nativeBuildInputs = [ cmake pkgconfig vala ]; |
There was a problem hiding this comment.
ninja is preferred with cmake.
There was a problem hiding this comment.
It doesn't seem to enjoy that.
ninja: error: loading 'build.ninja': No such file or directory
There was a problem hiding this comment.
It is depends on the order, I think. See my package above.
There was a problem hiding this comment.
I've tried to put cmake before or after ninja in that list, no difference :/
There was a problem hiding this comment.
Oh, right. The problem is the manual configurePhase. That should not be needed. Again, see #35472 (comment)
There was a problem hiding this comment.
Ah, missed that. Seems to build fine without it. Added ninja as well and amended my commit :)
pkgs/top-level/all-packages.nix
Outdated
| @@ -20701,6 +20701,11 @@ with pkgs; | |||
|
|
|||
| iterm2 = callPackage ../applications/misc/iterm2 {}; | |||
|
|
|||
| sequeler = callPackage ../applications/misc/sequeler { | |||
| libgee = libgee_0_8; | |||
There was a problem hiding this comment.
We should get rid of this, gnome3.libgee is the current version.
etu
force-pushed
the
sequeler
branch
2 times, most recently
from
dd45120
to
f3bcb9c
Compare
etu
force-pushed
the
sequeler
branch
2 times, most recently
from
18d8e0e
to
f7f5277
Compare
|
@jtojnar Now it actually builds! :) |
|
Merged as 3dfe50f. Thanks. |
Motivation for this change
It seems like a nice package.
cc @jtojnar maybe?
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)