Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoPackage: disable cache creation #35435

Merged
merged 1 commit into from Feb 24, 2018
Merged

buildGoPackage: disable cache creation #35435

merged 1 commit into from Feb 24, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 24, 2018 •
edited

Motivation for this change

Since 1.10 go tries create a cache directory in the user's home, which fails since home does not exists for our nix builder. Therefore this pull request's disable go's attempt to cache builds.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
buildGoPackage: disable go 1.10 cache
aafd5a6 
This disables annoying error messages that the go cache in /homeless-shelter cannot be created.
@Mic92
Copy link
Member Author

Mic92 commented Feb 24, 2018

cc @cstrahan

@Mic92 Mic92 merged commit 221510c into NixOS:master Feb 24, 2018
@Mic92 Mic92 deleted the go-build branch February 24, 2018 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adisbladis adisbladis adisbladis approved these changes

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
6.topic: golang 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @adisbladis @orivej @GrahamcOfBorg