Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: fixed mime types #35458

Merged
merged 1 commit into from Feb 24, 2018
Merged

nautilus: fixed mime types #35458

merged 1 commit into from Feb 24, 2018

Conversation

mimame
Copy link
Member

@mimame mimame commented Feb 24, 2018

Fixed #12280

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 labels Feb 24, 2018
Mic92
Mic92 reviewed Feb 24, 2018
View reviewed changes
pkgs/desktops/gnome-3/core/nautilus/default.nix
@@ -21,6 +21,7 @@ stdenv.mkDerivation rec {
# Thumbnailers
--prefix XDG_DATA_DIRS : "${gdk_pixbuf}/share"
--prefix XDG_DATA_DIRS : "${librsvg}/share"
--prefix XDG_DATA_DIRS : "${shared_mime_info}/share"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about?

       --prefix XDG_DATA_DIRS : "${gdk_pixbuf}/share:${librsvg}/share:${shared_mime_info}/share"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or even --prefix XDG_DATA_DIRS : "${stdenv.lib.makeSearchPath "share" [ gdk_pixbuf librsvg shared_mime_info ]}"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the tips. Changed 👍

@Mic92
Copy link
Member

Mic92 commented Feb 24, 2018

@GrahamcOfBorg build gnome3.nautilus

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘nautilus-3.26.2’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/desktops/gnome-3/core/nautilus/default.nix:6 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

[ 34%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSCommandLineAPIHost.cpp.o
[ 34%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSBarProp.cpp.o
[ 34%] Building CXX object Source/WebCore/CMakeFiles/WebCoreDerivedSources.dir/__/__/DerivedSources/WebCore/JSWebGPUTextureDescriptor.cpp.o
building of '/nix/store/w97rh4yqvkcljgzl705bhhl1v55pq9jd-webkitgtk-2.18.6.drv' timed out after 3200 seconds
cannot build derivation '/nix/store/5mdxil58py8mfwjgcymmgl2qwny25sy9-gnome-online-accounts-3.26.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hvxkf6yf38wl8bzmwhi1r9lhn89bv9c7-libgdata-0.17.9.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/22rwi0cr43698744cr519sw8a31z75h1-evolution-data-server-3.26.3.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/g6fhcnp935xhivk4k6cl7m65wq29xkcs-tracker-miners-2.0.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/w7l7l2s44qg05ijk8sl6dz37hvmbanhj-nautilus-3.26.2.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/w7l7l2s44qg05ijk8sl6dz37hvmbanhj-nautilus-3.26.2.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/ScriptExecutable.cpp.o
[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/SetConstructor.cpp.o
[ 18%] Building CXX object Source/JavaScriptCore/CMakeFiles/JavaScriptCore.dir/runtime/SetIteratorPrototype.cpp.o
building of ‘/nix/store/dyl81wpgjsr8wr59pn1nri87kx05waby-webkitgtk-2.18.6.drv’ timed out after 3600 seconds
cannot build derivation ‘/nix/store/s0abp6ipn5vq3c0ip304771aw3if590v-gnome-online-accounts-3.26.2.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/y83h33z0y24ah3r4ayl3vi83ph4207fp-libgdata-0.17.9.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/sjq5gbcnx7wqig9g4j98wrzvpz794q65-evolution-data-server-3.26.3.drv’: 3 dependencies couldn't be built
cannot build derivation ‘/nix/store/n1zv8b5318s1nn3jb60r4m8xn2qll7qn-tracker-miners-2.0.3.drv’: 1 dependencies couldn't be built
cannot build derivation ‘/nix/store/sj9prhv14fd95rc891mb48lmi60m21aw-nautilus-3.26.2.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/sj9prhv14fd95rc891mb48lmi60m21aw-nautilus-3.26.2.drv’ failed

@jtojnar jtojnar merged commit b7a6c54 into NixOS:master Feb 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mimame @Mic92 @GrahamcOfBorg @jtojnar