Add pam option to enable Google Authenticator #34728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Feb 9, 2018
nixos/modules/security/pam.nix
Outdated
| @@ -46,6 +46,16 @@ let | |||
| ''; | |||
| }; | |||
|
|
|||
| google2FA = mkOption { | |||
There was a problem hiding this comment.
Looks good to me. Would be googleAuthenticator be more self-explanatory then google2FA?
There was a problem hiding this comment.
Considering that there are other config settings that we might want to support later, it might make sense to "namespace" the config option like so:
google2FA = {
enable = mkOption {
default = false;
type = types.bool;
description = ''
If set, users with enabled Google Authenticator (created
<filename>~/.google_authenticator</filename>) will be required
to provide Google Authenticator token to log in.
'';
};
};
There was a problem hiding this comment.
The additional namespace is a very good idea.
authenticator seemed like a longish word. I have very little idea about conventions here. I am happy to change it.
There was a problem hiding this comment.
For me it was more about being consistent with what upstream calls it.
|
I have amended the change according to your instructions. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I couldn't find this option anywhere, and I used it on my Fedora, that I've replaced with NixOS (yay!), so I want it here as well.
Things done
(Not much yet, I am a total noob, please be gentle).
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)