Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fpdf: init at 1.7.2 #34733

Merged
merged 1 commit into from Feb 8, 2018
Merged

fpdf: init at 1.7.2 #34733

merged 1 commit into from Feb 8, 2018

Conversation

oxzi
Copy link
Member

@oxzi oxzi commented Feb 8, 2018

Motivation for this change

Adds the pyfpdf-package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@oxzi oxzi requested a review from FRidh as a code owner February 8, 2018 12:18
FRidh
FRidh requested changes Feb 8, 2018
View reviewed changes
pkgs/development/python-modules/fpdf/default.nix Outdated
buildPythonPackage rec {
pname = "fpdf";
version = "1.7.2";
name = "${pname}-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name attribute is added by buildPython* and should therefore be removed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed.

@FRidh
Copy link
Member

FRidh commented Feb 8, 2018

@GrahamcOfBorg build python2.pkgs.fpdf python3.pkgs.fpdf

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

reading manifest file 'fpdf.egg-info/SOURCES.txt'
writing manifest file 'fpdf.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/krxq2wp9bapbqxknb4rziawb6nvy49v0-python2.7-fpdf-1.7.2
/nix/store/zb8fa9cp3h3ck0xfhc989fi4n8smiha1-python3.6-fpdf-1.7.2

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

reading manifest file 'fpdf.egg-info/SOURCES.txt'
writing manifest file 'fpdf.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/2vybf8y51np4wnh3n1kbabq5hqxdxf41-python2.7-fpdf-1.7.2
/nix/store/jvvw3kx5l999swghqjqhdfm2626iq5l2-python3.6-fpdf-1.7.2

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

reading manifest file 'fpdf.egg-info/SOURCES.txt'
writing manifest file 'fpdf.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/syfz91abzkchdkg5qrfs9x96ylzb5gbi-python2.7-fpdf-1.7.2
/nix/store/ry08vsxzb66c5w11aaw231pbdkwxrab6-python3.6-fpdf-1.7.2

@FRidh
Copy link
Member

FRidh commented Feb 8, 2018 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

@oxzi
Copy link
Member Author

oxzi commented Feb 8, 2018

@FRidh: Thanks for your feedback. Does the package fits now?

dotlambda
dotlambda reviewed Feb 8, 2018
View reviewed changes
pkgs/development/python-modules/fpdf/default.nix
@@ -0,0 +1,21 @@
{ stdenv, lib, writeText, buildPythonPackage, fetchPypi }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where are stdenv and writeText used?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aah, I just pressed the big green button. But indeed, don't add parameters that are not used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I copied the template from an older Python-package PR and forgot to remove those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make sure to remove them with the next update. Not important right now.

@FRidh FRidh merged commit 28e0126 into NixOS:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh requested changes

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oxzi @FRidh @GrahamcOfBorg @dotlambda