Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

heaptrack: 2017-10-30 -> 2018-01-28, enable chart goodness #34723

Merged
merged 3 commits into from Feb 8, 2018
Merged

heaptrack: 2017-10-30 -> 2018-01-28, enable chart goodness #34723

merged 3 commits into from Feb 8, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Feb 8, 2018

Upgrade, but mostly enable charting goodness by adding kdiagram dep.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘heaptrack-2018-01-28’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/development/tools/profiling/heaptrack/default.nix:25 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28/lib/heaptrack/libexec/heaptrack_interpret
shrinking /nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28/lib/heaptrack/libheaptrack_inject.so
shrinking /nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28/lib/heaptrack/libheaptrack_preload.so
strip is /nix/store/5qj61lcvzlap87rf6blvf8p577d482bv-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28/lib  /nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28/bin 
patching script interpreter paths in /nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28
/nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28/bin/heaptrack: interpreter directive changed from "/bin/sh" to "/nix/store/yq03c2ny43mc24j7dq5riznzb09ddhpq-bash-4.4-p12/bin/sh"
checking for references to /tmp/nix-build-heaptrack-2018-01-28.drv-0 in /nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28...
postPatchMkspecs
/nix/store/nawv0ms7hvbmsggpjdk5ddi3b9mbkrfb-heaptrack-2018-01-28

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

shrinking /nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28/lib/heaptrack/libheaptrack_preload.so
shrinking /nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28/bin/heaptrack_gui
shrinking /nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28/bin/heaptrack_print
strip is /nix/store/xmpjypwjmp2qi1chs5kr0hacnh161ls4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28/lib  /nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28/bin
patching script interpreter paths in /nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28
/nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28/bin/heaptrack: interpreter directive changed from "/bin/sh" to "/nix/store/7fxbh1yhagvwbdrmdyyy5ghcjhwjndhs-bash-4.4-p12/bin/sh"
checking for references to /build in /nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28...
postPatchMkspecs
/nix/store/sqafcnawyxcpgbf3a9lh5fj6gk8grzmw-heaptrack-2018-01-28

@adisbladis adisbladis merged commit 7876f66 into NixOS:master Feb 8, 2018
@adisbladis
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @adisbladis