cataclysm-dda{,-git}: miscellaneous updates #34729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove cmath include (introduced by 97c484a) since the current gcc/clang works fine without it. - Suppress known compiler warnings instead of removing -Werror flag.
Previously the version shown in the title was 0.C, not distinguishable from the stable version.
You can install the console version with `cataclysm-dda{,-git}.override { tiles = false; }`.
mnacamura
changed the title
mnacamura
force-pushed
the
cdda-misc-updates
branch
from
7825372
to
e1e4fa5
Compare
mnacamura
force-pushed
the
cdda-misc-updates
branch
from
e1e4fa5
to
a2df3ee
Compare
|
Could anyone kindly review this? |
|
I'm looking into it but I can only test on NixOS. |
rnhmjoj
approved these changes
Feb 16, 2018
|
I'm really happy about the tiles option and the version string in the main menu. |
|
Thank you |
|
Thank you guys for reviewing and merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Basically maintenances of cataclysm-dda{,-git} packages.
Things done
Maintenance things
Minor enhancements
cataclysm-dda.override { tiles = false; }Tested using sandboxing (nix.useSandbox on NixOS, or option
build-use-sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nox --run "nox-review wip"Tested execution of all binary files (usually in
./result/bin/)Fits CONTRIBUTING.md.