rename: addition #34719
Merged
rename: addition #34719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a utility that just happens to be implemented in Perl so I think it is better put in, e.g., |
rycee
reviewed
Feb 8, 2018
pkgs/top-level/perl-packages.nix
Outdated
| description = "Bulk rename files according to a Perl rewrite expression"; | ||
| homepage = http://search.cpan.org/~pederst/rename-1.9/bin/rename.PL; | ||
| maintainers = with maintainers; [ mkg ]; | ||
| license = "unknown"; |
There was a problem hiding this comment.
This should be
license = with stdenv.lib.licenses; [ artistic1 gpl1Plus ];
according to the LICENSE file in the repo.
- moved from perl-packages to pkgs/tools/misc/rename - corrected license - switched to fetching from github
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Package alternative rename command which allows file renames to be specified via a perl regex.
Things done
Package has been built and installed by hand in user environment via nix-build/nix-env.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)