Fixing serialization of classes with incompatible serialize signature #3156
Conversation
AntonBikineev
force-pushed
the
fix_3134
branch
from
6b25fb4
to
3cff7c8
Compare
hpx/runtime/serialization/access.hpp
Outdated
| struct two_chars | ||
| { | ||
| char _[2]; | ||
| }; |
There was a problem hiding this comment.
Can we use std::true_type and std::false_type here?
There was a problem hiding this comment.
Not that I can think of.
Do you mean to use std::true/false_type as the return types for the test functions? If so, I don't think it makes a big difference. If you mean to inherit from std::true/false_type, then see the related discussion in #3134 why it didn't work for gcc.
|
@hkaiser thanks for letting me work on this! |
hpx/runtime/serialization/access.hpp
Outdated
|
|
||
| public: | ||
| static constexpr bool value = | ||
| sizeof(test<T>(0)) == sizeof(two_chars); |
There was a problem hiding this comment.
related to the above discussion ... I was thinking of why for example value = decltype(test<T>(0))::value; didn't work. It looks like this is unrelated to the discussion in #3134. If this is the only way to get it to work, there's nothing one can do, right?
AntonBikineev
force-pushed
the
fix_3134
branch
from
0ab6e0e
to
241a985
Compare
|
@sithhell yeah, I agree. It does look better now. |
This fixes #3134