align C ported memsearch code - need to handle array[length] properly #5037
+26
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... otherwise code doing utf8 str scan might fail with array-out-of-index resolves GH-2036
headius
approved these changes
Feb 13, 2018
| } | ||
| else { | ||
| h = '\0'; // (C) ary end - due y+m at rb_memsearch_qs_utf8 | ||
| } | ||
| if (h < 0xC0) { | ||
| return h + 256; |
There was a problem hiding this comment.
This will always return 256 at string end...is that correct?
There was a problem hiding this comment.
yep - should return the very same as the (original) C code when reaching \0 boundary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... otherwise code doing utf8 str scan might fail with array-out-of-index
resolves GH-5036
someone with C knowledge please review, seems to me that MRI handles the case without special care :
at
rb_memsearch_qs_utf8_hash(byte[] xBytes, final int x)whilex == xBytes.length