Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

manage.py with proper exit codes #252

Closed
wants to merge 2 commits into from
Closed

Conversation

rsh7
Copy link
Contributor

@rsh7 rsh7 commented Feb 8, 2018

Previous PR for this file: #250
I mistakenly pushed the last PR for this file directly from the master and it became difficult to handle other commits.
Kindly, reconsider this PR.

@alastair
Copy link
Collaborator

Thanks for the patch 🎉. I made a small change to return 1 instead of -1 and merged it (a176bde),
it's more common to use positive numbers for error codes. 1 is a standard "generic error" code which suits our purpose well.

I noticed that there was an error when running this script - you didn't import sys, which makes me think that you didn't actually test this change after making it. Please make sure that you test all changes that you make in the future before submitting the request!

@alastair alastair closed this Feb 12, 2018
@rsh7
Copy link
Contributor Author

rsh7 commented Feb 12, 2018

@alastair
Thank you! :)
I will take care of it from now on.

@rsh7 rsh7 deleted the exitcode branch April 3, 2018 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants