Add setting to configure group for systemd in Traefik #34749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mic92
reviewed
Feb 8, 2018
| @@ -64,6 +64,12 @@ in { | |||
| ''; | |||
| }; | |||
|
|
|||
| group = mkOption { | |||
| default = "docker"; | |||
There was a problem hiding this comment.
Should this be the default?
Running as docker is equivalent to running as root, because you can get root access by launching privileged containers.
There was a problem hiding this comment.
ah yes, sorry. That was meant to be traefik. Good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Using the Docker backend with traefik doesn't work as the socket is owned by the docker group. The traefik service is running in the traefik group.
This is a backward-compatible change which allows for changing the group so that the docker socket can be read.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)