Allow using RegisterPrimop to define constants. #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All plugins in plugin-files will be dlopened, allowing them to statically construct instances of the various Register* types Nix supports.
shlevy
force-pushed
the
register-constant
branch
from
41601ba
to
18ac8d4
Compare
shlevy
changed the title
This enables plugins to add new constants, as well as new primops.
shlevy
force-pushed
the
register-constant
branch
from
18ac8d4
to
081f14a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1854, this enables plugins to declare constants as well as primops. In particular, this allows a plugin to implement #1844 without requiring a dummy variable to the primop.
(Only the last commit here is novel, this is based on #1854)