Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pytest-sugar: 0.9.0 -> 0.9.1 #34738

Merged
merged 1 commit into from Feb 9, 2018
Merged

pythonPackages.pytest-sugar: 0.9.0 -> 0.9.1 #34738

merged 1 commit into from Feb 9, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner February 8, 2018 14:36
@dotlambda
Copy link
Member Author

@grahamc Something's wrong with @GrahamcOfBorg

@grahamc
Copy link
Member

grahamc commented Feb 8, 2018

Master is broken :( Looking in to it. Thanks.

@grahamc
Copy link
Member

grahamc commented Feb 8, 2018

(OfBorg is fine -- its just that someone broke master.)

@dotlambda
Copy link
Member Author

I hope it wasn't one of my own commits 🙈

@grahamc
Copy link
Member

grahamc commented Feb 8, 2018

nope, it is a memory issue I thought we'd hit one day ... and here we are :)

@grahamc
Copy link
Member

grahamc commented Feb 8, 2018

@GrahamcOfBorg eval

@dotlambda
Copy link
Member Author

It works! 🎉 Thank you!

@dotlambda
Copy link
Member Author

The list of packages nox-review wants to compile:

python27Packages.zerobin python36Packages.zerobin python36Packages.pytest-sugar python36Packages.cheroot python27Packages.portend mnemosyne python36Packages.ws4py python27Packages.WSME tribler python27Packages.cherrypy flexget python36Packages.WSME python36Packages.bugseverywhere python27Packages.bugseverywhere python36Packages.cherrypy python27Packages.ws4py python27Packages.cheroot python27Packages.pytest-sugar python36Packages.portend

All but tribbler and flexget compile just fine after the update. The other two were also broken before.

@Mic92 Mic92 merged commit 58278ae into NixOS:master Feb 9, 2018
@dotlambda dotlambda deleted the pytest-sugar branch March 21, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @grahamc @Mic92 @GrahamcOfBorg