linkchecker: 9.3 -> 9.3.1 #36228

tw-360vier · 2018-03-02T17:49:15Z

This also uses an older requests version because
linkchecker breaks with requests > 2.14.2.

Motivation for this change

Make linkchecker work

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions: Ubuntu
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-03-02T20:12:07Z

pkgs/tools/networking/linkchecker/default.nix

-  src = fetchurl {
-    url = "mirror://pypi/L/LinkChecker/${name}.tar.gz";
-    sha256 = "0v8pavf0bx33xnz1kwflv0r7lxxwj7vg3syxhy2wzza0wh6sc2pf";
+  # the original repository is abandoned, development is now happening here:


You should probably also update the homepage.

meta.homepage is updated.
i think i worked out all the kinks now :)

dotlambda · 2018-03-02T20:13:13Z

pkgs/tools/networking/linkchecker/default.nix

+  propagatedBuildInputs = with python2Packages;[ 
+    # pin requests version until next release.
+    # see: https://github.com/linkcheck/linkchecker/issues/76
+    (requests.overridePythonAttrs(old: rec {


Please have a look at https://github.com/NixOS/nixpkgs/blob/master/pkgs/servers/home-assistant/default.nix for how to pin dependency version.

dotlambda · 2018-03-02T20:13:33Z

pkgs/tools/networking/linkchecker/default.nix


 python2Packages.buildPythonApplication rec {
  name = "LinkChecker-${version}";
-  version = "9.3";
+  version = "9.3.1";

  buildInputs = with python2Packages ; [ pytest ];


checkInputs

dotlambda · 2018-03-02T20:13:46Z

pkgs/tools/networking/linkchecker/default.nix

@@ -1,22 +1,36 @@
-{ stdenv, lib, fetchurl, python2Packages, gettext }:
+{ stdenv, lib, fetchFromGitHub, python2Packages, gettext }:

 python2Packages.buildPythonApplication rec {
  name = "LinkChecker-${version}";


Please specify pname instead.

dotlambda · 2018-03-02T20:22:24Z

pkgs/tools/networking/linkchecker/default.nix

  patches = [
    ./add-no-robots-flag.patch
-    ./no-version-check.patch
+    ./e62e630e606a648ec2969551a74f2e68e9853f49.patch


Please use fetchpatch for that.

tw-360vier · 2018-03-05T14:13:24Z

@dotlambda
Thanks for your pointers!
i'm not very experienced in packaging python applications.

dotlambda

@tw-360vier I have done some cosmetic changes. Please pull these, do the requested changes and squash the commits. ~~Also please prefix your commit message with pythonPackages.~~ (EDIT: sorry, it's not in the pythonPackages namespace, no prefix then)

dotlambda · 2018-03-05T14:45:12Z

pkgs/tools/networking/linkchecker/default.nix

 python2Packages.buildPythonApplication rec {
-  name = "LinkChecker-${version}";
-  version = "9.3";
+  pname = "LinkChecker-${version}";


pname should not include the version. name will be set to "${pname}-${version}" automatically

dotlambda · 2018-03-05T14:46:50Z

pkgs/tools/networking/linkchecker/default.nix

@@ -35,7 +62,7 @@ python2Packages.buildPythonApplication rec {

  meta = {
    description = "Check websites for broken links";
-    homepage = https://wummel.github.io/linkchecker/;
+    homepage = https://linkcheck.github.io/linkchecker/;
    license = lib.licenses.gpl2;
    maintainers = with lib.maintainers; [ peterhoeg ];


Do you want to become a maintainer?

shure, i'll add myself when i update the pull request

tw-360vier · 2018-03-05T14:59:46Z

pkgs/tools/networking/linkchecker/default.nix

+  src = fetchFromGitHub {
+    owner = "linkcheck";
+    repo = "linkchecker";
+    rev = "v${version}";


@dotlambda
should "version" contain the "v" for the tag so it shows up in "${pname}-${version}" or is it allright this way?

No that should stay as it is.
The two major advantages of having pname and version are

we can use fetchPypi which expects pname and version (without a "v" prefix most of the time)

easier overriding because we do not need to override name nor pname

This also uses an older requests version because linkchecker breaks with requests > 2.14.2.

dotlambda · 2018-03-06T09:10:00Z

@GrahamcOfBorg build linkchecker

GrahamcOfBorg · 2018-03-06T09:10:46Z

Success on x86_64-linux (full log)

Partial log (click to expand)

tests/test_robotparser.py ss                                             [ 48%]
tests/test_robotstxt.py .................                                [ 60%]
tests/test_strformat.py ................                                 [ 71%]
tests/test_updater.py s                                                  [ 71%]
tests/test_url.py ....s..........s.....................                  [ 96%]
tests/test_urlbuild.py ....                                              [ 99%]
tests/logger/test_csvlog.py .                                            [100%]

==================== 139 passed, 10 skipped in 6.67 seconds ====================
/nix/store/wwzjsz9gm766asqlbcgns6qpzv06f8v2-LinkChecker-9.3.1

GrahamcOfBorg · 2018-03-06T09:11:44Z

Success on aarch64-linux (full log)

Partial log (click to expand)

tests/test_robotparser.py ss                                             [ 48%]
tests/test_robotstxt.py .................                                [ 60%]
tests/test_strformat.py ................                                 [ 71%]
tests/test_updater.py s                                                  [ 71%]
tests/test_url.py ....s..........s.....................                  [ 96%]
tests/test_urlbuild.py ....                                              [ 99%]
tests/logger/test_csvlog.py .                                            [100%]

=================== 139 passed, 10 skipped in 19.75 seconds ====================
/nix/store/l8j20q7zb191a1x4071lwv111kdfgk17-LinkChecker-9.3.1

dotlambda · 2018-03-06T09:13:09Z

Thanks a lot!

tw-360vier · 2018-03-06T10:38:01Z

Thank you!

GrahamcOfBorg added 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 2, 2018

dotlambda requested changes Mar 2, 2018

View reviewed changes

dotlambda added the 6.topic: python label Mar 2, 2018

tw-360vier force-pushed the fix-linkchecker branch from c146b3a to 775888b Compare March 5, 2018 14:10

GrahamcOfBorg removed the 6.topic: python label Mar 5, 2018

dotlambda requested changes Mar 5, 2018

View reviewed changes

tw-360vier commented Mar 5, 2018

View reviewed changes

linkchecker: 9.3 -> 9.3.1

93752a8

This also uses an older requests version because linkchecker breaks with requests > 2.14.2.

tw-360vier force-pushed the fix-linkchecker branch from 8adb862 to 93752a8 Compare March 5, 2018 15:15

dotlambda merged commit eae4965 into NixOS:master Mar 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

linkchecker: 9.3 -> 9.3.1 #36228

linkchecker: 9.3 -> 9.3.1 #36228

tw-360vier commented Mar 2, 2018

dotlambda Mar 2, 2018

tw-360vier Mar 5, 2018

dotlambda Mar 2, 2018

dotlambda Mar 2, 2018

dotlambda Mar 2, 2018

dotlambda Mar 2, 2018

tw-360vier commented Mar 5, 2018

dotlambda left a comment •

edited

dotlambda Mar 5, 2018

dotlambda Mar 5, 2018

tw-360vier Mar 5, 2018

tw-360vier Mar 5, 2018

dotlambda Mar 5, 2018

dotlambda commented Mar 6, 2018

GrahamcOfBorg commented Mar 6, 2018

GrahamcOfBorg commented Mar 6, 2018

dotlambda commented Mar 6, 2018

tw-360vier commented Mar 6, 2018

linkchecker: 9.3 -> 9.3.1 #36228

linkchecker: 9.3 -> 9.3.1 #36228

Conversation

tw-360vier commented Mar 2, 2018

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tw-360vier commented Mar 5, 2018

dotlambda left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dotlambda commented Mar 6, 2018

GrahamcOfBorg commented Mar 6, 2018

GrahamcOfBorg commented Mar 6, 2018

dotlambda commented Mar 6, 2018

tw-360vier commented Mar 6, 2018

dotlambda left a comment •

edited