Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libretro: add higan-sfc core #36238

Merged
merged 3 commits into from Mar 4, 2018
Merged

libretro: add higan-sfc core #36238

merged 3 commits into from Mar 4, 2018

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Mar 3, 2018
View reviewed changes
pkgs/misc/emulators/retroarch/cores.nix Outdated
@@ -215,6 +215,20 @@ in with stdenv.lib.licenses;
license = "Non-commercial";
};

higan-sfc = (mkLibRetroCore rec {
core = "higan-sfc";
src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless the repository contains submodules, fetchFromGitLab should be used.

@Mic92
Copy link
Member

Mic92 commented Mar 4, 2018

@GrahamcOfBorg build libretro.higan-sfc

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Package ‘libretro-higan-sfc-2017-06-04’ in /private/var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/misc/emulators/retroarch/cores.nix:38 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

                                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~^
g++ -o out/higan_sfc_libretro.so obj/libretro_sfc.o obj/libco.o obj/emulator.o obj/audio.o obj/video.o obj/resource.o obj/sfc-interface.o obj/sfc-system.o obj/sfc-controller.o obj/sfc-cartridge.o obj/sfc-memory.o obj/sfc-cpu.o obj/sfc-smp.o obj/sfc-dsp.o obj/sfc-ppu.o obj/sfc-expansion.o obj/sfc-satellaview.o obj/sfc-21fx.o obj/sfc-icd2.o obj/sfc-mcc.o obj/sfc-nss.o obj/sfc-event.o obj/sfc-sa1.o obj/sfc-superfx.o obj/sfc-armdsp.o obj/sfc-hitachidsp.o obj/sfc-necdsp.o obj/sfc-epsonrtc.o obj/sfc-sharprtc.o obj/sfc-spc7110.o obj/sfc-sdd1.o obj/sfc-obc1.o obj/sfc-msu1.o obj/sfc-bsmemory.o obj/sfc-sufamiturbo.o obj/gb-interface.o obj/gb-system.o obj/gb-memory.o obj/gb-cartridge.o obj/gb-cpu.o obj/gb-ppu.o obj/gb-apu.o obj/processor-arm7tdmi.o obj/processor-gsu.o obj/processor-hg51b.o obj/processor-lr35902.o obj/processor-spc700.o obj/processor-upd96050.o obj/processor-wdc65816.o -ldl -fopenmp -shared
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9cvrmmrr78jxkv0ki9cj4lhvlr82l0k1-libretro-higan-sfc-2017-06-04
shrinking /nix/store/9cvrmmrr78jxkv0ki9cj4lhvlr82l0k1-libretro-higan-sfc-2017-06-04/lib/retroarch/cores/higan_sfc_libretro.so
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9cvrmmrr78jxkv0ki9cj4lhvlr82l0k1-libretro-higan-sfc-2017-06-04/lib  /nix/store/9cvrmmrr78jxkv0ki9cj4lhvlr82l0k1-libretro-higan-sfc-2017-06-04/bin 
patching script interpreter paths in /nix/store/9cvrmmrr78jxkv0ki9cj4lhvlr82l0k1-libretro-higan-sfc-2017-06-04
checking for references to /tmp/nix-build-libretro-higan-sfc-2017-06-04.drv-0 in /nix/store/9cvrmmrr78jxkv0ki9cj4lhvlr82l0k1-libretro-higan-sfc-2017-06-04...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

g++ -o out/higan_sfc_libretro.so obj/libretro_sfc.o obj/libco.o obj/emulator.o obj/audio.o obj/video.o obj/resource.o obj/sfc-interface.o obj/sfc-system.o obj/sfc-controller.o obj/sfc-cartridge.o obj/sfc-memory.o obj/sfc-cpu.o obj/sfc-smp.o obj/sfc-dsp.o obj/sfc-ppu.o obj/sfc-expansion.o obj/sfc-satellaview.o obj/sfc-21fx.o obj/sfc-icd2.o obj/sfc-mcc.o obj/sfc-nss.o obj/sfc-event.o obj/sfc-sa1.o obj/sfc-superfx.o obj/sfc-armdsp.o obj/sfc-hitachidsp.o obj/sfc-necdsp.o obj/sfc-epsonrtc.o obj/sfc-sharprtc.o obj/sfc-spc7110.o obj/sfc-sdd1.o obj/sfc-obc1.o obj/sfc-msu1.o obj/sfc-bsmemory.o obj/sfc-sufamiturbo.o obj/gb-interface.o obj/gb-system.o obj/gb-memory.o obj/gb-cartridge.o obj/gb-cpu.o obj/gb-ppu.o obj/gb-apu.o obj/processor-arm7tdmi.o obj/processor-gsu.o obj/processor-hg51b.o obj/processor-lr35902.o obj/processor-spc700.o obj/processor-upd96050.o obj/processor-wdc65816.o -ldl -fopenmp -shared
installing
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/v3q0598v9d8xq13h527wzk4622z8g0d5-libretro-higan-sfc-2017-06-04
shrinking /nix/store/v3q0598v9d8xq13h527wzk4622z8g0d5-libretro-higan-sfc-2017-06-04/lib/retroarch/cores/higan_sfc_libretro.so
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/v3q0598v9d8xq13h527wzk4622z8g0d5-libretro-higan-sfc-2017-06-04/lib  /nix/store/v3q0598v9d8xq13h527wzk4622z8g0d5-libretro-higan-sfc-2017-06-04/bin
patching script interpreter paths in /nix/store/v3q0598v9d8xq13h527wzk4622z8g0d5-libretro-higan-sfc-2017-06-04
checking for references to /build in /nix/store/v3q0598v9d8xq13h527wzk4622z8g0d5-libretro-higan-sfc-2017-06-04...
/nix/store/v3q0598v9d8xq13h527wzk4622z8g0d5-libretro-higan-sfc-2017-06-04

@Mic92 Mic92 merged commit 799178f into NixOS:master Mar 4, 2018
@ghost ghost deleted the libretro branch March 4, 2018 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @GrahamcOfBorg