Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hierarchy, periodic priority and throttling schedulers #3186

Merged
merged 5 commits into from Mar 19, 2018
Merged

Remove hierarchy, periodic priority and throttling schedulers #3186

merged 5 commits into from Mar 19, 2018

Conversation

msimberg
Copy link
Contributor

Proposed Changes

  • Remove hierarchy, periodic priority and throttling schedulers
  • Clean up documentation for command line options related to schedulers
    • all affinity options can be used with all schedulers
    • remove short options for schedulers from documentation (I'm thinking these should be completely disallowed, or be explicitly set, but I'm not sure yet so leaving them for now. Opinions?)
  • Remove ensure_hwloc function (missed this when making hwloc compulsory)

@hkaiser hkaiser added this to the 1.1.0 milestone Feb 20, 2018
@biddisco
Copy link
Contributor

I'd like to see this merged ASAP because the recent work we've done on improving schedulers, task creation, cleanup is much easier with these schedulers removed.

@hkaiser
Copy link
Member

hkaiser commented Mar 16, 2018

I'd like to see this merged ASAP because the recent work we've done on improving schedulers, task creation, cleanup is much easier with these schedulers removed.

@biddisco we're waiting for somebody to review and approve this PR for it to be merged...

@biddisco biddisco mentioned this pull request Mar 16, 2018
Closed
sithhell
sithhell approved these changes Mar 19, 2018
View reviewed changes
Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@msimberg msimberg merged commit 8dace88 into STEllAR-GROUP:master Mar 19, 2018
@msimberg msimberg deleted the remove-schedulers branch March 19, 2018 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sithhell sithhell sithhell approved these changes

Assignees
No one assigned
Labels
category: threadmanager type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@msimberg @biddisco @hkaiser @sithhell