New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixnote2: init at 2.0.2 #35217
nixnote2: init at 2.0.2 #35217
Conversation
I'm kinda disappointed this isn't a utility for storing notes in the Nix store (for some reason that is wonderful, I'm sure!)... :P |
@GrahamcOfBorg build nixnote |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
I honestly am unsure, should this perhaps be called "nixnote2" instead? Upstream maybe prefers that it looks like, but split on repology.org is 4 and 4: https://repology.org/metapackages/?search=nixnote . Only brought it up once saw the installed binary was called "nixnote2". |
TIL about repology.org :) good point, I'll rename it: even if it is a 4/4 on repology, the most relevant distros (IMO) adopted |
Thanks for iterating on this, sorry for all the one-at-a-time comments! This builds and seems to work at a glance, although I don't have an evernote account. (Yet? This app does look neat....) Poking a bit it seems upstream's install rule leaves a lot to be desired:
In particular there are various scripts for installation and packaging, this one for example seems to have steps to address each of the above and a number of other things that may or may not be needed/useful: https://github.com/baumgarr/nixnote2/blob/master/package_scripts/copy_files.sh#L56 Since hunspell is a dep--does spell checking work? Not sure if that's usually automatic or if something more is needed. Hmm, not sure how to best handle these things reasonably cleanly. Can you look at this a bit? FWIW, here's what Arch does: https://aur.archlinux.org/cgit/aur.git/tree/PKGBUILD?h=nixnote2 I link it to point out that they're doing something re:plugins and optional webcam support? I wouldn't worry about webcam support unless that was important to you, but thought I'd bring it to your attention in case that's something you would like :). |
thanks for taking a look! hunspell is a build dep required even when the hunspell plugin is not built. I'll tweak some knobs later! |
You've done a great job, don't mean to be a nag. I definitely don't think plugins are a priority! |
Agreed, I'll merge it into single |
@GrahamcOfBorg build nixnote2 |
Failure on x86_64-darwin (full log) Partial log (click to expand)
|
Success on aarch64-linux (full log) Partial log (click to expand)
|
Success on x86_64-linux (full log) Partial log (click to expand)
|
Motivation for this change
Adds nixnote: an Evernote clone for linux
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)