Multiple modules in support of POE-1.367 #35218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
POE: init at 1.367
POETestLoops: init at 1.360
TestPodNo404s: init at 0.02
Note that I encountered bugs as part of this effort as documented in
the following CPAN bug tickets:
https://rt.cpan.org/Ticket/Display.html?id=124495
POE-1.367 failed t/10_units/01_pod/03_pod_no404s.t
https://rt.cpan.org/Ticket/Display.html?id=124496
POE-1.367 failed t/10_units/01_pod/04_pod_linkcheck.t
... and these bugs are addressed by the perl-POE-1.367-pod_no404s.patch
and perl-POE-1.367-pod_linkcheck.patch files included with this patch,
respectively.
|
Sorry for the newbie confusion - I will close this PR and resubmit as three individual PRs for each of the three modules. |
|
Multiple simple packages in one PR are ok. Your pull request just went under, which happen sometimes. |
|
Thanks for letting me know. I'm happy resubmitting multiple PRs for related
modules in future as it is better suited to the automated handling and also
easier to monitor progress from my end.
Yes, I submitted the following PRs to the CPAN author so that hopefully
those patches will be applied upstream at some point in future:
- rcaputo/poe#25
- rcaputo/poe#26
FYI, I will be submitting a new PR for the POE module once the current PR
for POE::Test::Loops (#36115) is
successfully merged.
Thanks again!
…On Wed, Feb 28, 2018 at 11:50 AM, Jörg Thalheim ***@***.***> wrote:
Multiple simple packages in one PR are ok. Your pull request just went
under, which happen sometimes.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#35218 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/Aiwngn-mb5fXCWAiNXCe9fAGDb2raHtwks5tZT2fgaJpZM4SL8T5>
.
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POE: init at 1.367
POETestLoops: init at 1.360
TestPodNo404s: init at 0.02
Note that I encountered bugs as part of this effort as documented in the following CPAN bug tickets:
... and these bugs are addressed by the perl-POE-1.367-pod_no404s.patch and perl-POE-1.367-pod_linkcheck.patch files included with this patch, both of which have been submitted as PRs to https://github.com/rcaputo/poe.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)