Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pijul: 0.8.0 -> 0.8.3 #35225

Closed
wants to merge 1 commit into from
Closed

pijul: 0.8.0 -> 0.8.3 #35225

wants to merge 1 commit into from

Conversation

yrashk
Copy link
Contributor

@yrashk yrashk commented Feb 20, 2018

The update was not straightforward. There was this failure after an update of the version:

error: the lock file needs to be updated but --locked was passed to prevent this

Adding a hook to the derivation helped with this, but I am not sure this is the best way
to handle this situation.

Motivation for this change

Pijul 0.8.3 is required to work with nest.pijul.com

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

jtojnar
jtojnar reviewed Feb 20, 2018
View reviewed changes
pkgs/applications/version-management/pijul/default.nix
};

preBuild = ''
cargo update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work in sandbox?

@nlewo
Copy link
Member

nlewo commented Feb 22, 2018

@GrahamcOfBorg build pijul

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/native'
cp: -r not specified; omitting directory 'target/release/examples'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/hrmw9js06rb247hfwsrb9y6dvl7mqwx9-pijul-0.8.3
shrinking /nix/store/hrmw9js06rb247hfwsrb9y6dvl7mqwx9-pijul-0.8.3/bin/pijul
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hrmw9js06rb247hfwsrb9y6dvl7mqwx9-pijul-0.8.3/bin 
patching script interpreter paths in /nix/store/hrmw9js06rb247hfwsrb9y6dvl7mqwx9-pijul-0.8.3
checking for references to /tmp/nix-build-pijul-0.8.3.drv-0 in /nix/store/hrmw9js06rb247hfwsrb9y6dvl7mqwx9-pijul-0.8.3...
/nix/store/hrmw9js06rb247hfwsrb9y6dvl7mqwx9-pijul-0.8.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/cyksc1wgpc6n6zz8j1mqly31zhzi2hbc-rust_cargo-vendor-0.1.13
shrinking /nix/store/cyksc1wgpc6n6zz8j1mqly31zhzi2hbc-rust_cargo-vendor-0.1.13/bin/cargo-vendor
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/cyksc1wgpc6n6zz8j1mqly31zhzi2hbc-rust_cargo-vendor-0.1.13/lib  /nix/store/cyksc1wgpc6n6zz8j1mqly31zhzi2hbc-rust_cargo-vendor-0.1.13/bin
patching script interpreter paths in /nix/store/cyksc1wgpc6n6zz8j1mqly31zhzi2hbc-rust_cargo-vendor-0.1.13
checking for references to /build in /nix/store/cyksc1wgpc6n6zz8j1mqly31zhzi2hbc-rust_cargo-vendor-0.1.13...
cannot build derivation '/nix/store/qws2x2k2jnkgmjxza5fxajdaggy8y03a-pijul-0.8.3-vendor.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/y8c2z64kcspw6lk3z940f2fkjsagzfg8-pijul-0.8.3.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/y8c2z64kcspw6lk3z940f2fkjsagzfg8-pijul-0.8.3.drv' failed

@7c6f434c
Copy link
Member

Is sandbox enabled on Aarch64? It looks like the command failing shouldn't really be arch-dependent…

@infinisil
Copy link
Member

I'd like this to get merged, building again so we can see the full logs for aarch64 (they get removed after 7 days)
@GrahamcOfBorg build pijul

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pijul

Partial log (click to expand)

cp: -r not specified; omitting directory 'target/release/build'
cp: -r not specified; omitting directory 'target/release/.fingerprint'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/yw7yc543jc09zzs4xcc8s9g864c00xsi-pijul-0.8.3
shrinking /nix/store/yw7yc543jc09zzs4xcc8s9g864c00xsi-pijul-0.8.3/bin/pijul
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/yw7yc543jc09zzs4xcc8s9g864c00xsi-pijul-0.8.3/bin
patching script interpreter paths in /nix/store/yw7yc543jc09zzs4xcc8s9g864c00xsi-pijul-0.8.3
checking for references to /build in /nix/store/yw7yc543jc09zzs4xcc8s9g864c00xsi-pijul-0.8.3...
/nix/store/yw7yc543jc09zzs4xcc8s9g864c00xsi-pijul-0.8.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: pijul

Partial log (click to expand)

cannot build derivation '/nix/store/jd5sxbq7sa5x6xzrchkypp2q87drplry-rust_serde_derive-1.0.18.drv': 6 dependencies couldn't be built
cannot build derivation '/nix/store/9qa50x766wwvaxxvd10nk1p4xviidfi2-rust_crates-io-0.11.0.drv': 30 dependencies couldn't be built
cannot build derivation '/nix/store/qvjhfy22hgqk2lg6r3mk5ym84vj7s9h8-rust_docopt-0.8.1.drv': 19 dependencies couldn't be built
cannot build derivation '/nix/store/142y4gkx972zvpp0gqxhcwq9rqf7ad21-rust_git2-curl-0.7.0.drv': 20 dependencies couldn't be built
cannot build derivation '/nix/store/i55qyd3liqs7yqq0fhr94y6vk02r4jib-rust_ignore-0.2.2.drv': 18 dependencies couldn't be built
cannot build derivation '/nix/store/j2qmwqmgifin75d0z8wdl1968jr1s9h5-rust_cargo-0.22.0.drv': 78 dependencies couldn't be built
cannot build derivation '/nix/store/w7y9d8gq23lfxb4qd2yfkhc8k0z54hma-rust_cargo-vendor-0.1.13.drv': 79 dependencies couldn't be built
cannot build derivation '/nix/store/mnh5zzk5gqgj4i7x99pbldyyjzd7vx8p-pijul-0.8.3-vendor.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/jr8f77dzpnv12lmki7ipf764dr3272j8-pijul-0.8.3.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/jr8f77dzpnv12lmki7ipf764dr3272j8-pijul-0.8.3.drv' failed

@infinisil
Copy link
Member

Apparently version 0.9.0 from crates.io is needed in order to use nest.pijul.com due to a format change. I used carnix to be able to build it on nix, not sure what's the best way to proceed. I'm hoping for an official 0.9.0 release soon.

@infinisil infinisil mentioned this pull request Apr 20, 2018
Closed
8 tasks
@yrashk
Copy link
Contributor Author

yrashk commented Apr 22, 2018

Superseded by #39317

@yrashk yrashk closed this Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yrashk @nlewo @GrahamcOfBorg @7c6f434c @infinisil @jtojnar