Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages.Mail-Sendmail: init at 0.80 #35223

Merged
merged 3 commits into from Feb 28, 2018

Conversation

limeytexan
Copy link
Contributor

Motivation for this change

Add Mail::Sendmail module from CPAN.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title perl-Mail-Sendmail: init at 0.80 perlPackages.Mail-Sendmail: init at 0.80 Feb 21, 2018
@Mic92
Copy link
Member

Mic92 commented Feb 21, 2018

@GrahamcOfBorg build perlPackages.Mail-Sendmail

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

�[31;1merror:�[0m attribute 'Mail-Sendmail' in selection path 'perlPackages.Mail-Sendmail' not found

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

error: attribute 'Mail-Sendmail' in selection path 'perlPackages.Mail-Sendmail' not found

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

error: attribute 'Mail-Sendmail' in selection path 'perlPackages.Mail-Sendmail' not found

@Mic92
Copy link
Member

Mic92 commented Feb 21, 2018

@GrahamcOfBorg build perlPackages.MailSendmail

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

t/getnameinfo.t (Wstat: 512 Tests: 13 Failed: 2)
  Failed tests:  9-10
  Non-zero exit status: 2
Files=7, Tests=136,  4 wallclock secs ( 0.10 usr  0.04 sys +  0.57 cusr  0.12 csys =  0.83 CPU)
Result: FAIL
Failed 1/7 test programs. 2/136 subtests failed.
make: *** [Makefile:1012: test_dynamic] Error 255
builder for '/nix/store/7gri6r3pm2dlijm1pyv5d1g1dsjb28nn-perl-Socket-2.020.drv' failed with exit code 2
cannot build derivation '/nix/store/f9igyjwxcmgc3gp4mlb4553kg6iyc263-perl-Mail-Sendmail-0.80.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/f9igyjwxcmgc3gp4mlb4553kg6iyc263-perl-Mail-Sendmail-0.80.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

t/getnameinfo.t (Wstat: 512 Tests: 13 Failed: 2)
  Failed tests:  9-10
  Non-zero exit status: 2
Files=7, Tests=136,  3 wallclock secs ( 0.06 usr  0.02 sys +  0.22 cusr  0.05 csys =  0.35 CPU)
Result: FAIL
Failed 1/7 test programs. 2/136 subtests failed.
make: *** [Makefile:1012: test_dynamic] Error 255
builder for ‘/nix/store/24ivyp12hq1nl29y0ap0iy9v1m57pmc4-perl-Socket-2.020.drv’ failed with exit code 2
cannot build derivation ‘/nix/store/rcwsyi3agkrdmxy9mhp7kmxzcpdnh10v-perl-Mail-Sendmail-0.80.drv’: 1 dependencies couldn't be built
error: build of ‘/nix/store/rcwsyi3agkrdmxy9mhp7kmxzcpdnh10v-perl-Mail-Sendmail-0.80.drv’ failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

Test Summary Report
-------------------
t/original.t (Wstat: 0 Tests: 2 Failed: 1)
  Failed test:  2
Files=1, Tests=2, 77 wallclock secs ( 0.02 usr  0.01 sys +  0.01 cusr  0.00 csys =  0.04 CPU)
Result: FAIL
Failed 1/1 test programs. 1/2 subtests failed.
make: *** [Makefile:861: test_dynamic] Error 255
builder for '/nix/store/mk9kgq11kib1hgx94rjlfp833ppwqaj4-perl-Mail-Sendmail-0.80.drv' failed with exit code 2
error: build of '/nix/store/mk9kgq11kib1hgx94rjlfp833ppwqaj4-perl-Mail-Sendmail-0.80.drv' failed

@Mic92
Copy link
Member

Mic92 commented Feb 21, 2018

The error is related to Socket: http://cpansearch.perl.org/src/PEVANS/Socket-2.027/t/getaddrinfo.t
a dependency of this module. Looks like it only fails in nix build sandbox. Also I am surprised why it needs DNS to resolve 127.0.0.1. The lazy patch would be to just remove t/getaddrinfo.t and call it a day.
I don't think we need to test getaddrinfo on Nixos. This is pretty basic stuff.

@Mic92
Copy link
Member

Mic92 commented Feb 28, 2018

I fixed perlPackages.Socket here: fd0a32e

@Mic92
Copy link
Member

Mic92 commented Feb 28, 2018

@GrahamcOfBorg build perlPackages.MailSendmail

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

post-installation fixup
Moving /nix/store/l5d9p1ks03lzip4zys5lv4jhh56gir9l-perl-Mail-Sendmail-0.80/share/man/man3 to /nix/store/3wnrzyq6gc6rlf1fbyn1wk1j7qw2f84m-perl-Mail-Sendmail-0.80-devdoc/share/man/man3
Removing empty /nix/store/l5d9p1ks03lzip4zys5lv4jhh56gir9l-perl-Mail-Sendmail-0.80/share/man/ and (possibly) its parents
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/l5d9p1ks03lzip4zys5lv4jhh56gir9l-perl-Mail-Sendmail-0.80/lib
patching script interpreter paths in /nix/store/l5d9p1ks03lzip4zys5lv4jhh56gir9l-perl-Mail-Sendmail-0.80
gzipping man pages under /nix/store/3wnrzyq6gc6rlf1fbyn1wk1j7qw2f84m-perl-Mail-Sendmail-0.80-devdoc/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/3wnrzyq6gc6rlf1fbyn1wk1j7qw2f84m-perl-Mail-Sendmail-0.80-devdoc
/nix/store/l5d9p1ks03lzip4zys5lv4jhh56gir9l-perl-Mail-Sendmail-0.80

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/1d2gfp2y3k1090zn68krp4fg8mn0q1a4-perl-Mail-Sendmail-0.80/lib 
patching script interpreter paths in /nix/store/1d2gfp2y3k1090zn68krp4fg8mn0q1a4-perl-Mail-Sendmail-0.80
checking for references to /tmp/nix-build-perl-Mail-Sendmail-0.80.drv-0 in /nix/store/1d2gfp2y3k1090zn68krp4fg8mn0q1a4-perl-Mail-Sendmail-0.80...
shrinking RPATHs of ELF executables and libraries in /nix/store/8qmr8f2kzmi307vk3k5lp1889xc90q4j-perl-Mail-Sendmail-0.80-devdoc
gzipping man pages under /nix/store/8qmr8f2kzmi307vk3k5lp1889xc90q4j-perl-Mail-Sendmail-0.80-devdoc/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/8qmr8f2kzmi307vk3k5lp1889xc90q4j-perl-Mail-Sendmail-0.80-devdoc
checking for references to /tmp/nix-build-perl-Mail-Sendmail-0.80.drv-0 in /nix/store/8qmr8f2kzmi307vk3k5lp1889xc90q4j-perl-Mail-Sendmail-0.80-devdoc...
/nix/store/1d2gfp2y3k1090zn68krp4fg8mn0q1a4-perl-Mail-Sendmail-0.80

@Mic92 Mic92 merged commit f0e0bd1 into NixOS:master Feb 28, 2018
@limeytexan
Copy link
Contributor Author

limeytexan commented Feb 28, 2018 via email

@limeytexan limeytexan deleted the perl-Mail-Sendmail branch February 28, 2018 11:36
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/s99h1pc3yf43v176xzljbribrg4crn8r-perl-Mail-Sendmail-0.80/lib
patching script interpreter paths in /nix/store/s99h1pc3yf43v176xzljbribrg4crn8r-perl-Mail-Sendmail-0.80
checking for references to /build in /nix/store/s99h1pc3yf43v176xzljbribrg4crn8r-perl-Mail-Sendmail-0.80...
shrinking RPATHs of ELF executables and libraries in /nix/store/n6n9gi07481vfiax6x4xd1qdx18pci4h-perl-Mail-Sendmail-0.80-devdoc
gzipping man pages under /nix/store/n6n9gi07481vfiax6x4xd1qdx18pci4h-perl-Mail-Sendmail-0.80-devdoc/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/n6n9gi07481vfiax6x4xd1qdx18pci4h-perl-Mail-Sendmail-0.80-devdoc
checking for references to /build in /nix/store/n6n9gi07481vfiax6x4xd1qdx18pci4h-perl-Mail-Sendmail-0.80-devdoc...
/nix/store/s99h1pc3yf43v176xzljbribrg4crn8r-perl-Mail-Sendmail-0.80

@limeytexan
Copy link
Contributor Author

limeytexan commented Mar 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants