Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clamsmtp: fix build after linuxHeaders update to 4.15 #36329

Merged
merged 1 commit into from Mar 5, 2018

Conversation

Ekleog
Copy link
Member

@Ekleog Ekleog commented Mar 5, 2018

Motivation for this change

clamsmtp stopped building after fd0f15f11c0, according to git bisect. This patch fixes the issue, I'm sending it upstream right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 5, 2018

@GrahamcOfBorg build clamsmtp

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10
shrinking /nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10/sbin/clamsmtpd
gzipping man pages under /nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10/sbin 
patching script interpreter paths in /nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10
checking for references to /tmp/nix-build-clamsmtp-1.10.drv-0 in /nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10...
moving /nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10/sbin/* to /nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10/bin
/nix/store/i1758z53lmm8wqnir066frqbib8rjkps-clamsmtp-1.10

@Mic92 Mic92 merged commit c1052bf into NixOS:master Mar 5, 2018
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10
shrinking /nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10/sbin/clamsmtpd
gzipping man pages under /nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10/sbin
patching script interpreter paths in /nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10
checking for references to /build in /nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10...
moving /nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10/sbin/* to /nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10/bin
/nix/store/ss674zcpl805d3vs7293n1y2dmb7iism-clamsmtp-1.10

@Ekleog
Copy link
Member Author

Ekleog commented Mar 5, 2018

Thanks! :)

@Ekleog Ekleog deleted the fix-clamsmtp branch March 5, 2018 09:50
@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Partial log (click to expand)

make[2]: Nothing to be done for 'install-data-am'.
make[2]: Leaving directory '/private/tmp/nix-build-clamsmtp-1.10.drv-0/clamsmtp-1.10'
make[1]: Leaving directory '/private/tmp/nix-build-clamsmtp-1.10.drv-0/clamsmtp-1.10'
post-installation fixup
gzipping man pages under /nix/store/crdq36d5xr58l0yvcskn4r3vp4v7qzd5-clamsmtp-1.10/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/crdq36d5xr58l0yvcskn4r3vp4v7qzd5-clamsmtp-1.10/sbin
patching script interpreter paths in /nix/store/crdq36d5xr58l0yvcskn4r3vp4v7qzd5-clamsmtp-1.10
moving /nix/store/crdq36d5xr58l0yvcskn4r3vp4v7qzd5-clamsmtp-1.10/sbin/* to /nix/store/crdq36d5xr58l0yvcskn4r3vp4v7qzd5-clamsmtp-1.10/bin
/nix/store/crdq36d5xr58l0yvcskn4r3vp4v7qzd5-clamsmtp-1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants