maintainers: remove null fields #36347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grahamc
referenced
this pull request
Mar 5, 2018
|
A follow-up fix to this should probably assert the structure of each maintainer is correct, with a minimum of name / github / email set to strings. |
vcunat
approved these changes
Mar 5, 2018
|
I thought I had manually removed all cc @peti |
|
Thank you very much for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@peti noticed nix-env was emitting errors to stderr about invalid meta field maintainers. Turns out the structured PR from @Profpatsch added some null fields to the maintainer list, causing this problem. I fixed the only two null fields present, and nix-env now shows no errors.
See: f7da7fa#commitcomment-27930583