Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a dirty hack in the python wheel extractor that did not work if a… #36339

Closed
wants to merge 1 commit into from

Conversation

adevress
Copy link
Contributor

@adevress adevress commented Mar 5, 2018

Fix a dirty hack in the python wheel extractor that did not work if any "-" char exist in the nix store path....

Motivation for this change

Make possible to install nix wheel-based package when the nix store path is something else than /nix/store..... and has a "-" char inside.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Jan 6, 2019

@GrahamcOfBorg eval

@adevress adevress closed this Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants